[cli] Use getNodeBinPaths() in vc dev
#10225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for the "dev command" of a Project to work better in monorepos, where the dev server might live up the node_modules hierarchy within the repo.
TooTallNate
requested review from
EndangeredMassa,
styfle,
cb1kenobi and
Ethan-Arrowood
as code owners
🦋 Changeset detectedLatest commit: f2351a8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
styfle
reviewed
Jul 17, 2023
cb1kenobi
approved these changes
Jul 19, 2023
Ethan-Arrowood
approved these changes
Jul 19, 2023
Merged
TooTallNate
pushed a commit
that referenced
this pull request
Jul 25, 2023
# Releases ## vercel@31.1.0 ### Minor Changes - Add 'Environment' column to 'vc list' with new '--environment' filter and pipe URLs to stdout ([#10239](#10239)) ### Patch Changes - Update `proxy-agent` to v6.3.0 ([#10226](#10226)) - Use `getNodeBinPaths()` in `vc dev` ([#10225](#10225)) - Updated dependencies \[[`b1c14cde0`](b1c14cd), [`ce4633fe4`](ce4633f)]: - @vercel/next@3.9.1 - @vercel/static-build@1.3.42 ## @vercel/frameworks@1.5.0 ### Minor Changes - Add `ignorePackageJsonScript` configuration for Framework command settings to ignore the `package.json` script. ([#10228](#10228)) Enable this mode for Storybook's `buildCommand`, since it should not invoke the "build" script, which is most likely designated for the frontend app build. ## @vercel/fs-detectors@4.1.1 ### Patch Changes - Updated dependencies \[[`ce4633fe4`](ce4633f)]: - @vercel/frameworks@1.5.0 ## @vercel/next@3.9.1 ### Patch Changes - Fix pages and app router i18n handling ([#10243](#10243)) ## @vercel/static-build@1.3.42 ### Patch Changes - Add `ignorePackageJsonScript` configuration for Framework command settings to ignore the `package.json` script. ([#10228](#10228)) Enable this mode for Storybook's `buildCommand`, since it should not invoke the "build" script, which is most likely designated for the frontend app build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for the "dev command" of a Project to work better in monorepos, where the dev server might live up the node_modules hierarchy within the repo.