[cli] Fix team validation bug where you are apart of a team #10092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cb1kenobi
requested review from
TooTallNate,
EndangeredMassa,
styfle and
Ethan-Arrowood
as code owners
🦋 Changeset detectedLatest commit: 5c75c83 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
cb1kenobi
added
area: cli
semver: minor
|
This did fix the issue for me. I think we should add some tests to make sure we preserve this behavior. |
|
Test added! |
styfle
reviewed
Jun 9, 2023
packages/cli/test/unit/util/projects/get-project-by-deployment.test.ts
Outdated
Show resolved
Hide resolved
styfle
reviewed
Jun 9, 2023
packages/cli/test/unit/util/projects/get-project-by-deployment.test.ts
Outdated
Show resolved
Hide resolved
….test.ts Co-authored-by: Steven <steven@ceriously.com>
….test.ts Co-authored-by: Steven <steven@ceriously.com>
styfle
approved these changes
Jun 12, 2023
EndangeredMassa
approved these changes
Jun 12, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When consolidating the deployment team validation, a bug was introduced where the command would error if the user was currently using a team. The logic was meant to copy the logic in
getDeploymentByIdOrURL(): https://github.com/vercel/vercel/blob/main/packages/cli/src/util/deploy/get-deployment-by-id-or-url.ts#L80.