[cli] Move readme copy logic to a helper function for vc link
#10084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncc has an issue with detecting + rewriting this file path for some reason. Moving to a helper function should work around that issue. Fixing: ``` Error: ENOENT: no such file or directory, open '/node_modules/vercel/projects/VERCEL_DIR_README.txt' ```
TooTallNate
requested review from
EndangeredMassa,
styfle,
cb1kenobi and
Ethan-Arrowood
as code owners
🦋 Changeset detectedLatest commit: cda8a24 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
styfle
approved these changes
Jun 7, 2023
cb1kenobi
reviewed
Jun 7, 2023
Comment on lines
+289
to
+292
| await writeFile( | ||
| join(path, VERCEL_DIR, VERCEL_DIR_README), | ||
| await readFile(join(__dirname, 'VERCEL_DIR_README.txt'), 'utf8') | ||
| ); |
There was a problem hiding this comment.
suggestion (non-blocking): Node 14 introduce import { copyFile } from 'fs/promises';: https://nodejs.org/dist/latest-v18.x/docs/api/fs.html#fspromisescopyfilesrc-dest-mode
Suggested change
| await writeFile( | |
| join(path, VERCEL_DIR, VERCEL_DIR_README), | |
| await readFile(join(__dirname, 'VERCEL_DIR_README.txt'), 'utf8') | |
| ); | |
| await copyFile( | |
| join(__dirname, 'VERCEL_DIR_README.txt'), | |
| join(path, VERCEL_DIR, VERCEL_DIR_README) | |
| ); |
EndangeredMassa
approved these changes
Jun 7, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ncc has an issue with detecting + rewriting this file path for some reason. Moving to a helper function should work around that issue.
Fixing: