[cli] Add support for vc deploy --prebuilt command with repo link
#10083
+109
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TooTallNate
requested review from
EndangeredMassa,
styfle,
cb1kenobi and
Ethan-Arrowood
as code owners
🦋 Changeset detectedLatest commit: c5d486f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
TooTallNate
commented
Jun 7, 2023
Comment on lines
+310
to
+318
| // For repo-style linking, update `cwd` to be the Project | ||
| // subdirectory when `rootDirectory` setting is defined | ||
| if ( | ||
| link.status === 'linked' && | ||
| link.repoRoot && | ||
| link.project.rootDirectory | ||
| ) { | ||
| cwd = join(cwd, link.project.rootDirectory); | ||
| } |
There was a problem hiding this comment.
This is the main change. The rest is just a move of the existing code to a point after link is defined.
| @@ -355,6 +305,66 @@ export default async (client: Client): Promise<number> => { | |||
| throw new Error(`"org" is not defined`); | |||
| } | |||
|
|
|||
| // build `--prebuilt` | |||
| if (argv['--prebuilt']) { | |||
There was a problem hiding this comment.
I can't test this because I can't get vc build to work. When I try it in a project dir:
$ vc build
Vercel CLI 30.2.1-e945958
? Please select a Project: vercel-cli-monorepo-test-two
? No Project Settings found locally. Run `vercel pull` for retrieving them? [Y/n] y
Error: ENOENT: no such file or directory, chdir '/Users/smassa/source/demo/vercel-cli-monorepo-test/packages/one' -> '/Users/smassa/source/demo/vercel-cli-monorepo-test/packages/one/packages/one'
and when I try it in the root, I hit an infinite loop:
$ vc build
Vercel CLI 30.2.1-e945958
? Please select a Project: vercel-cli-monorepo-test-one
? No Project Settings found locally. Run `vercel pull` for retrieving them? [Y/n] y
? Please select a Project: vercel-cli-monorepo-test-one
> Downloading `preview` Environment Variables for Project vercel-cli-monorepo-test-one
✅ Created .vercel/.env.preview.local file [109ms]
> Downloading project settings
✅ Downloaded project settings to ~/source/demo/vercel-cli-monorepo-test/packages/one/packages/one/.vercel/project.json [0ms]
? No Project Settings found locally. Run `vercel pull` for retrieving them? [Y/n] y
? Please select a Project: vercel-cli-monorepo-test-one
> Overwriting existing .vercel/.env.preview.local file
> Downloading `preview` Environment Variables for Project vercel-cli-monorepo-test-one
> No changes found.
✅ Updated .vercel/.env.preview.local file [113ms]
> Downloading project settings
✅ Downloaded project settings to ~/source/demo/vercel-cli-monorepo-test/packages/one/packages/one/.vercel/project.json [0ms]
? No Project Settings found locally. Run `vercel pull` for retrieving them? [Y/n] y
? Please select a Project:
● vercel-cli-monorepo-test-one
○ vercel-cli-monorepo-test-two
...
cb1kenobi
approved these changes
Jun 7, 2023
TooTallNate
added
pr: automerge
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When repo linked,
vc deploy --prebuiltwill change working directory to the Project root directory, instead of the repo root, so that the project's local.vercel/outputdirectory is what gets uploaded + deployed.