Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[next] support maxDuration in Next.js deployments #10069

Merged
merged 23 commits into from
Jul 14, 2023

Conversation

ecklf
Copy link
Member

@ecklf ecklf commented Jun 6, 2023

Follow up PR to vercel/next.js@8703c55 which reads the newly created function config manifest and patches in the options for resource creation.

@changeset-bot
Copy link

changeset-bot bot commented Jun 6, 2023

🦋 Changeset detected

Latest commit: 18df1bf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@vercel/next Minor
vercel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ecklf ecklf changed the title [node] add named exports for deployments [node] [next] support named maxDuration export configuration Jun 7, 2023
packages/build-utils/src/lambda.ts Outdated Show resolved Hide resolved
packages/static-config/test/index.test.ts Outdated Show resolved Hide resolved
@ecklf ecklf changed the title [node] [next] support named maxDuration export configuration [next] support named maxDuration export configuration Jun 30, 2023
@ecklf ecklf force-pushed the ecklf/ec-978-add-support-for-nextjs-deployments branch from 6607f49 to 8babccf Compare June 30, 2023 12:47
@ecklf ecklf changed the title [next] support named maxDuration export configuration [next] support maxDuration in Next.js deployments Jun 30, 2023
Copy link
Contributor

@nuta nuta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add tests 🙏

@ecklf
Copy link
Member Author

ecklf commented Jul 12, 2023

The failing test is caused by Next.js, but it should be fixed in the latest Next.js canary already. Which version is this test using?

It's pulling canary as far as I can see, I'll retrigger and see if it pulls the latest canary released an hour ago.

packages/next/src/utils.ts Outdated Show resolved Hide resolved
Co-authored-by: Steven <steven@ceriously.com>
nuta
nuta previously approved these changes Jul 14, 2023
Copy link
Contributor

@nuta nuta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Left some nitpicks and suggestions.

Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ecklf ecklf merged commit cae6015 into main Jul 14, 2023
104 checks passed
@ecklf ecklf deleted the ecklf/ec-978-add-support-for-nextjs-deployments branch July 14, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants