-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[next] support maxDuration in Next.js deployments #10069
Conversation
🦋 Changeset detectedLatest commit: 18df1bf The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
6607f49
to
8babccf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add tests 🙏
It's pulling canary as far as I can see, I'll retrigger and see if it pulls the latest canary released an hour ago. |
packages/next/test/fixtures/00-app-dir-segment-options/next.config.js
Outdated
Show resolved
Hide resolved
packages/next/test/fixtures/00-app-dir-segment-options/vercel.json
Outdated
Show resolved
Hide resolved
Co-authored-by: Steven <steven@ceriously.com>
…ps://github.com/vercel/vercel into ecklf/ec-978-add-support-for-nextjs-deployments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Left some nitpicks and suggestions.
packages/next/test/fixtures/00-app-dir-segment-options/data-context.js
Outdated
Show resolved
Hide resolved
…ps://github.com/vercel/vercel into ecklf/ec-978-add-support-for-nextjs-deployments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Follow up PR to vercel/next.js@8703c55 which reads the newly created function config manifest and patches in the options for resource creation.