feat(login): add --manual flag
#9998
Merged
+453
−95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
chris-olszewski
force-pushed
the
olszewski/feat_manual_login
branch
from
362062a to
bf7393f
Compare
chris-olszewski
force-pushed
the
olszewski/feat_manual_login
branch
from
bf7393f to
1f24fd6
Compare
NicholasLYang
approved these changes
Feb 19, 2025
anthonyshew
reviewed
Feb 19, 2025
|
|
||
| The team id of the Remote Cache team. | ||
| Value will be passed as `teamId` in the querystring for all Remote Cache HTTP calls. | ||
| Must start with `team_` or it will not be used. |
There was a problem hiding this comment.
Future task: Should we warn on this?
There was a problem hiding this comment.
Or we remove this behavior? I do not know the reasoning behind it 🤷
There was a problem hiding this comment.
Possibly. I think I'd err on caution for now. I don't like changes for auth things without 100% confidence, and we're already making changes. Unless you're 100% on it, I'd just kick the can down the road.
anthonyshew
reviewed
Feb 19, 2025
anthonyshew
reviewed
Feb 19, 2025
anthonyshew
reviewed
Feb 19, 2025
anthonyshew
reviewed
Feb 19, 2025
Co-authored-by: Anthony Shew <anthony.shew@vercel.com>
Co-authored-by: Anthony Shew <anthony.shew@vercel.com>
Co-authored-by: Anthony Shew <anthony.shew@vercel.com>
Co-authored-by: Anthony Shew <anthony.shew@vercel.com>
This was referenced Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently setting up a custom remote cache requires editing multiple files and setting the
TURBO_TOKENenv var for every command you run that requires the remote cache. Introducingturbo login --manualwhich will edit all configuration files required to allow forturboto use the remote cache without setting any env vars or editing any files.This command is equivalent to
turbo loginandturbo linkwhen using the Vercel remote cache.This PR also fixes a bug in our
rewrite_jsonmodule where we didn't correctly rewrite paths if they had more than one element.I suggest reviewing this PR commit by commit.
Testing Instructions
Added unit tests, but going through the flow is the best way to test this.
Screen.Recording.2025-02-18.at.12.20.48.PM.mov