feat(link): add --yes and --scope flags to link
#9466
Merged
+152
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Skipped Deployments
|
turbo-orchestrator
bot
added
the
area: docs
chris-olszewski
approved these changes
Nov 19, 2024
Comment on lines
188
to
189
| if !yes { | ||
| if !should_link_remote_cache(base, &repo_root_with_tilde)? { |
There was a problem hiding this comment.
Up to you if flattening is helpful.
Suggested change
| if !yes { | |
| if !should_link_remote_cache(base, &repo_root_with_tilde)? { | |
| if !yes && !should_link_remote_cache(base, &repo_root_with_tilde)? { |
There was a problem hiding this comment.
I found that a little too complex for my taste tbh
There was a problem hiding this comment.
Ugh ok clippy disagrees
NicholasLYang
force-pushed
the
nicholasyang/link-yes
branch
from
55fe171 to
59a0ff9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds
--yesand--scopeflagsTesting Instructions
Added tests for parsing those flags