Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Turborepo): Disable the new corepack notification #7901

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

gsoltis
Copy link
Contributor

@gsoltis gsoltis commented Apr 3, 2024

Description

  • sets COREPACK_ENABLE_DOWNLOAD_PROMPT=0 for the integration tests

Newer versions of corepack have extra text output when downloading a version, but the environment variable can disable it

Testing Instructions

Observe GH Actions integration tests passing.

Closes TURBO-2753

Copy link

vercel bot commented Apr 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview Apr 3, 2024 11:26pm
9 Ignored Deployments
Name Status Preview Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Apr 3, 2024 11:26pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Apr 3, 2024 11:26pm
examples-gatsby-web ⬜️ Ignored (Inspect) Apr 3, 2024 11:26pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Apr 3, 2024 11:26pm
examples-native-web ⬜️ Ignored (Inspect) Apr 3, 2024 11:26pm
examples-svelte-web ⬜️ Ignored (Inspect) Apr 3, 2024 11:26pm
examples-tailwind-web ⬜️ Ignored (Inspect) Apr 3, 2024 11:26pm
examples-vite-web ⬜️ Ignored (Inspect) Apr 3, 2024 11:26pm
rust-docs ⬜️ Ignored (Inspect) Apr 3, 2024 11:26pm

Copy link
Contributor

github-actions bot commented Apr 3, 2024

🟢 Turbopack Benchmark CI successful 🟢

Thanks

Copy link
Contributor

github-actions bot commented Apr 3, 2024

🟢 CI successful 🟢

Thanks

@gsoltis gsoltis assigned gsoltis and unassigned gsoltis Apr 4, 2024
@gsoltis gsoltis marked this pull request as ready for review April 4, 2024 00:02
@gsoltis gsoltis requested a review from a team as a code owner April 4, 2024 00:02
@gsoltis
Copy link
Contributor Author

gsoltis commented Apr 4, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants