Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(turborepo): Package Detection #7549

Merged
merged 15 commits into from
Mar 5, 2024
Merged

refactor(turborepo): Package Detection #7549

merged 15 commits into from
Mar 5, 2024

Commits on Mar 4, 2024

  1. Factored out package detection into a trait with different implementa… 

    …tions: a default package graph implementation

and a turbo.json aware implementation
    @NicholasLYang
    NicholasLYang committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    0c030cf View commit details
    Browse the repository at this point in the history

  2. Removed global deps from change mapper and put into package detector.… 

    … Also added a test
    @NicholasLYang
    NicholasLYang committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    e2edc50 View commit details
    Browse the repository at this point in the history

  3. PR feedback

    @NicholasLYang
    NicholasLYang committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    045df53 View commit details
    Browse the repository at this point in the history

  4. Adding back global file detection because apparently we don't treat r… 

    …oot package changes as full monorepo invalidations
    @NicholasLYang
    NicholasLYang committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    276a632 View commit details
    Browse the repository at this point in the history

  5. Refactoring package mapping to use a PackageDetection struct

    @NicholasLYang
    NicholasLYang committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    d1a40c4 View commit details
    Browse the repository at this point in the history

  6. pulling out global deps into a different package detector, so we can 

    have the correct behavior for the conservative approach
    @NicholasLYang
    NicholasLYang committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    8bf8215 View commit details
    Browse the repository at this point in the history

  7. Removing change post-rebase

    @NicholasLYang
    NicholasLYang committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    4233065 View commit details
    Browse the repository at this point in the history

  8. Fix call site and comment

    @NicholasLYang
    NicholasLYang committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    c22d2ec View commit details
    Browse the repository at this point in the history

  9. Tidying up

    @NicholasLYang
    NicholasLYang committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    3386cd3 View commit details
    Browse the repository at this point in the history

  10. Fixing tests

    @NicholasLYang
    NicholasLYang committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    c3f48bb View commit details
    Browse the repository at this point in the history

  11. Fix test

    @NicholasLYang
    NicholasLYang committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    1b9de4d View commit details
    Browse the repository at this point in the history

  12. Update crates/turborepo-lib/src/global_deps_package_detector.rs 

    Co-authored-by: Chris Olszewski <chris.olszewski@vercel.com>
    @NicholasLYang @chris-olszewski
    NicholasLYang and chris-olszewski committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    fdbbae6 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2024

  1. PR feedback

    @NicholasLYang
    NicholasLYang committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    b191cb3 View commit details
    Browse the repository at this point in the history

  2. PR feedback

    @NicholasLYang
    NicholasLYang committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    c4ca9e2 View commit details
    Browse the repository at this point in the history

  3. Fix up names

    @NicholasLYang
    NicholasLYang committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    fb4f85b View commit details
    Browse the repository at this point in the history