Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update swc_core to v0.79.22 #5575

Merged
merged 5 commits into from
Jul 21, 2023
Merged

Update swc_core to v0.79.22 #5575

merged 5 commits into from
Jul 21, 2023

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Jul 20, 2023 •
edited

Description

Update swc_core to v0.79.22 and other SWC crates to the latest.

This is for further next.js work: https://vercel.slack.com/archives/C02HY34AKME/p1689768597095499

Testing Instructions

Closes WEB-1300

next.js counterpart: vercel/next.js#52945

@vercel
Copy link

vercel bot commented Jul 20, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-designsystem-docs 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jul 21, 2023 7:44am
examples-vite-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jul 21, 2023 7:44am
turbo-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 21, 2023 7:44am
8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Jul 21, 2023 7:44am
examples-cra-web ⬜️ Ignored (Inspect) Visit Preview Jul 21, 2023 7:44am
examples-gatsby-web ⬜️ Ignored (Inspect) Jul 21, 2023 7:44am
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Jul 21, 2023 7:44am
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Jul 21, 2023 7:44am
examples-nonmonorepo ⬜️ Ignored (Inspect) Visit Preview Jul 21, 2023 7:44am
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Jul 21, 2023 7:44am
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Jul 21, 2023 7:44am

@kdy1 kdy1 mentioned this pull request Jul 20, 2023
Merged
@kdy1 kdy1 marked this pull request as ready for review July 20, 2023 14:34
@kdy1 kdy1 requested review from a team as code owners July 20, 2023 14:34
@github-actions
Copy link
Contributor

github-actions bot commented Jul 20, 2023 •
edited

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@github-actions
Copy link
Contributor

⚠️ This change may fail to build next-swc.

Logs 

packages/next-swc/crates/next-build/src/next_build.rs:470:36: �[38;5;9merror[E0061]: this method takes 3 arguments but 2 arguments were supplied
error: could not compile `next-build` (lib) due to previous error

See job summary for details

@github-actions
Copy link
Contributor

Linux Benchmark for ee51375

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 6276.21µs ± 116.85µs 6201.08µs ± 30.90µs -1.20%
bench_hmr_to_eval/Turbopack CSR/1000 modules 5719.68µs ± 68.53µs 5671.90µs ± 43.41µs -0.84%
bench_startup/Turbopack CSR/1000 modules 1027.66ms ± 1.98ms 1028.21ms ± 3.05ms +0.05%

@sokra sokra merged commit 1a950b0 into main Jul 21, 2023
45 of 48 checks passed
@sokra sokra deleted the kdy1/swc-core-79-1 branch July 21, 2023 08:46
@github-actions
Copy link
Contributor

Windows Benchmark for ee51375

Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 15.72ms ± 0.01ms 15.89ms ± 0.02ms +1.07% +0.65%
Click to view full benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 15.72ms ± 0.01ms 15.89ms ± 0.02ms +1.07% +0.65%
bench_hmr_to_eval/Turbopack CSR/1000 modules 15.88ms ± 0.09ms 16.32ms ± 0.92ms +2.75%
bench_startup/Turbopack CSR/1000 modules 4983.34ms ± 140.62ms 4630.58ms ± 74.63ms -7.08%

kodiakhq bot pushed a commit to vercel/next.js that referenced this pull request Jul 21, 2023
@kdy1 @sokra
Update swc_core to v0.79.22 (#52945)
84820c9 
### What?

Update swc_core to `v0.79.22` and other SWC crates to the latest.
### Why?

This is for further next.js work: https://vercel.slack.com/archives/C02HY34AKME/p1689768597095499


### How?

Closes WEB-1299

turbopack counterpart: vercel/turbo#5575

Co-authored-by: Tobias Koppers <1365881+sokra@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ForsakenHarmony ForsakenHarmony ForsakenHarmony approved these changes

@chris-olszewski chris-olszewski Awaiting requested review from chris-olszewski chris-olszewski is a code owner automatically assigned from vercel/turbo-oss

@NicholasLYang NicholasLYang Awaiting requested review from NicholasLYang NicholasLYang is a code owner automatically assigned from vercel/turbo-oss

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kdy1 @ForsakenHarmony @sokra