Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Module Trait #5477

Merged
merged 5 commits into from
Jul 10, 2023
Merged

Module Trait #5477

merged 5 commits into from
Jul 10, 2023

Conversation

sokra
Copy link
Member

@sokra sokra commented Jul 7, 2023 •
edited

Description

First step in having separate traits for Source, Module and Outputs.

next.js PR: vercel/next.js#52401

@sokra sokra requested a review from a team as a code owner July 7, 2023 15:14
@vercel
Copy link

vercel bot commented Jul 7, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-kitchensink-blog 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jul 10, 2023 10:17am
10 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Jul 10, 2023 10:17am
examples-cra-web ⬜️ Ignored (Inspect) Visit Preview Jul 10, 2023 10:17am
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Jul 10, 2023 10:17am
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Jul 10, 2023 10:17am
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Jul 10, 2023 10:17am
examples-nonmonorepo ⬜️ Ignored (Inspect) Visit Preview Jul 10, 2023 10:17am
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Jul 10, 2023 10:17am
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Jul 10, 2023 10:17am
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Jul 10, 2023 10:17am
turbo-site ⬜️ Ignored (Inspect) Visit Preview Jul 10, 2023 10:17am

@sokra sokra changed the title Sokra/module trait Module Trait Jul 7, 2023
@sokra sokra mentioned this pull request Jul 7, 2023
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2023 •
edited

✅ This change can build next-swc

alexkirsz
alexkirsz approved these changes Jul 7, 2023
View reviewed changes
crates/turbopack-core/src/module.rs Show resolved Hide resolved
crates/turbopack-core/src/raw_module.rs Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2023 •
edited

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2023

Linux Benchmark for add00da

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 5876.64µs ± 31.07µs 5863.86µs ± 33.38µs -0.22%
bench_hmr_to_eval/Turbopack CSR/1000 modules 5511.94µs ± 32.22µs 5510.72µs ± 21.82µs -0.02%
bench_startup/Turbopack CSR/1000 modules 915.88ms ± 0.70ms 920.74ms ± 2.67ms +0.53%

@github-actions
Copy link
Contributor

github-actions bot commented Jul 9, 2023

Linux Benchmark for 69c35e9

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 5376.27µs ± 29.49µs 5351.92µs ± 32.52µs -0.45%
bench_hmr_to_eval/Turbopack CSR/1000 modules 5024.94µs ± 20.76µs 5226.34µs ± 185.77µs +4.01%
bench_startup/Turbopack CSR/1000 modules 799.62ms ± 1.36ms 804.91ms ± 2.37ms +0.66%

@github-actions
Copy link
Contributor

Linux Benchmark for 38c9d30

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 7677.93µs ± 35.89µs 7667.71µs ± 23.81µs -0.13%
bench_hmr_to_eval/Turbopack CSR/1000 modules 7002.67µs ± 33.48µs 7431.20µs ± 308.59µs +6.12%
bench_startup/Turbopack CSR/1000 modules 889.12ms ± 4.19ms 887.42ms ± 10.32ms -0.19%

@github-actions
Copy link
Contributor

MacOS Benchmark for 38c9d30

Test Base PR % Significant %
bench_hmr_to_eval/Turbopack CSR/1000 modules 26.96ms ± 0.13ms 29.98ms ± 1.00ms +11.17% +2.78%
Click to view full benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 27.05ms ± 0.09ms 27.52ms ± 0.16ms +1.73%
bench_hmr_to_eval/Turbopack CSR/1000 modules 26.96ms ± 0.13ms 29.98ms ± 1.00ms +11.17% +2.78%
bench_startup/Turbopack CSR/1000 modules 3006.51ms ± 35.43ms 3024.15ms ± 70.09ms +0.59%

@sokra sokra merged commit b910aac into main Jul 10, 2023
44 of 45 checks passed
@sokra sokra deleted the sokra/module-trait branch July 10, 2023 11:03
sokra added a commit to vercel/next.js that referenced this pull request Jul 10, 2023
@sokra @kodiakhq
turbopack: Module Trait (#52401)
8643014 
### What?

refactoring see vercel/turbo#5477

---------

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexkirsz alexkirsz alexkirsz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sokra @alexkirsz