Update nightly toolchain #5376

alexkirsz · 2023-06-24T14:57:34Z

Description

This updates the nightly toolchain from nightly-2023-03-09 to nightly-2023-07-03.

This PR includes Clippy fixes and rustfmt fixes (let else formatting, finally!)

Next.js PR: vercel/next.js#51757

Testing Instructions

CI

vercel · 2023-06-24T14:57:44Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
examples-gatsby-web	🔄 Building (Inspect)	Visit Preview	💬 Add feedback	Jul 7, 2023 1:50pm
examples-kitchensink-blog	🔄 Building (Inspect)	Visit Preview	💬 Add feedback	Jul 7, 2023 1:50pm
examples-svelte-web	🔄 Building (Inspect)	Visit Preview	💬 Add feedback	Jul 7, 2023 1:50pm

8 Ignored Deployments

Name	Status	Preview	Updated (UTC)
examples-basic-web	⬜️ Ignored (Inspect)	Visit Preview	Jul 7, 2023 1:50pm
examples-cra-web	⬜️ Ignored (Inspect)	Visit Preview	Jul 7, 2023 1:50pm
examples-designsystem-docs	⬜️ Ignored (Inspect)	Visit Preview	Jul 7, 2023 1:50pm
examples-native-web	⬜️ Ignored (Inspect)	Visit Preview	Jul 7, 2023 1:50pm
examples-nonmonorepo	⬜️ Ignored (Inspect)	Visit Preview	Jul 7, 2023 1:50pm
examples-tailwind-web	⬜️ Ignored (Inspect)	Visit Preview	Jul 7, 2023 1:50pm
examples-vite-web	⬜️ Ignored (Inspect)	Visit Preview	Jul 7, 2023 1:50pm
turbo-site	⬜️ Ignored (Inspect)	Visit Preview	Jul 7, 2023 1:50pm

github-actions · 2023-06-24T15:02:00Z

⚠️ This change may fail to build next-swc.

Logs

error: failed to select a version for `testing`.
    ... required by package `turbopack-binding v0.1.0 (https://github.com/vercel/turbo?rev=d51513057202cddeaec12cf439aad4f4915be72b#6bd45fee)`
    ... which satisfies git dependency `turbopack-binding` (locked to 0.1.0) of package `next-build v0.1.0 (/home/runner/work/turbo/turbo/packages/next-swc/crates/next-build)`
    ... which satisfies path dependency `next-build` (locked to 0.1.0) of package `next-swc-napi v0.0.0 (/home/runner/work/turbo/turbo/packages/next-swc/crates/napi)`
versions that meet the requirements `^0.33.20` are: 0.33.20

all possible versions conflict with previously selected packages.

  previously selected package `testing v0.33.19`
    ... which satisfies dependency `testing = "^0.33.19"` (locked to 0.33.19) of package `next-dev-tests v0.1.0 (/home/runner/work/turbo/turbo/packages/next-swc/crates/next-dev-tests)`

failed to select a version for `testing` which could resolve this conflict

See job summary for details

github-actions · 2023-06-24T15:18:39Z

⚠️ CI failed ⚠️

The following steps have failed in CI:

Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

ForsakenHarmony · 2023-06-24T18:10:00Z

crates/turbopack-ecmascript/src/code_gen.rs

-    (__ $ast_path:expr, $name:ident($arg:ident: &mut $ty:ident) $b:block) => {{
-        struct Visitor<T: Fn(&mut swc_core::ecma::ast::$ty) + Send + Sync> {
-            $name: T,
+    // This rule needs to be first, otherwise we run into the following error:


ah you figured it out

github-actions · 2023-06-24T19:41:42Z

Linux Benchmark for `ea41f17`

Click to view benchmark

Test	Base	PR	%
bench_hmr_to_commit/Turbopack CSR/1000 modules	10.71ms ± 0.05ms	10.60ms ± 0.04ms	-1.06%
bench_hmr_to_eval/Turbopack CSR/1000 modules	9617.06µs ± 38.18µs	10.17ms ± 0.53ms	+5.70%
bench_startup/Turbopack CSR/1000 modules	1098.63ms ± 2.82ms	1093.79ms ± 4.11ms	-0.44%

github-actions · 2023-06-24T20:20:21Z

MacOS Benchmark for `ea41f17`

Test	Base	PR	%	Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules	26.75ms ± 0.06ms	28.28ms ± 0.64ms	+5.70%	+0.47%

Click to view full benchmark

Test	Base	PR	%	Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules	26.75ms ± 0.06ms	28.28ms ± 0.64ms	+5.70%	+0.47%
bench_hmr_to_eval/Turbopack CSR/1000 modules	28.38ms ± 0.68ms	27.37ms ± 0.21ms	-3.56%
bench_startup/Turbopack CSR/1000 modules	3413.71ms ± 19.49ms	3482.55ms ± 88.73ms	+2.02%

alexkirsz · 2023-07-07T12:42:46Z

cli/internal/ffi/ffi.go

@@ -13,7 +13,7 @@ package ffi
 // #cgo linux,amd64,staticbinary LDFLAGS:   -L${SRCDIR} -lturborepo_ffi_linux_amd64 -lunwind
 // #cgo linux,arm64,!staticbinary LDFLAGS:   -L${SRCDIR} -lturborepo_ffi_linux_arm64 -lz
 // #cgo linux,amd64,!staticbinary LDFLAGS:   -L${SRCDIR} -lturborepo_ffi_linux_amd64 -lz
-// #cgo windows,amd64 LDFLAGS: -L${SRCDIR} -lturborepo_ffi_windows_amd64 -lole32 -lbcrypt -lws2_32 -luserenv
+// #cgo windows,amd64 LDFLAGS: -L${SRCDIR} -lturborepo_ffi_windows_amd64 -lole32 -lbcrypt -lws2_32 -luserenv -lntdll


This fixes a linker issue on windows:

cli:build: c:/programdata/chocolatey/lib/mingw/tools/install/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/11.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: D:/a/turbo/turbo/cli/internal/ffi/libturborepo_ffi_windows_amd64.a(std-331aac04ffc5fa95.std.fc65e66d7b5f576c-cgu.0.rcgu.o): in function `std::sys::windows::fs::open_link_no_reparse': cli:build: /rustc/22e9fe644ea710eec50cb0aabcae7fa8dd9fd675/library\std\src\sys\windows/fs.rs:829: undefined reference to `NtCreateFile' cli:build: c:/programdata/chocolatey/lib/mingw/tools/install/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/11.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: /rustc/22e9fe644ea710eec50cb0aabcae7fa8dd9fd675/library\std\src\sys\windows/fs.rs:858: undefined reference to `RtlNtStatusToDosError' cli:build: c:/programdata/chocolatey/lib/mingw/tools/install/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/11.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: D:/a/turbo/turbo/cli/internal/ffi/libturborepo_ffi_windows_amd64.a(std-331aac04ffc5fa95.std.fc65e66d7b5f576c-cgu.0.rcgu.o): in function `std::sys::windows::c::NtReadFile': cli:build: /rustc/22e9fe644ea710eec50cb0aabcae7fa8dd9fd675/library\std\src\sys\windows/c.rs:284: undefined reference to `NtReadFile' cli:build: c:/programdata/chocolatey/lib/mingw/tools/install/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/11.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: D:/a/turbo/turbo/cli/internal/ffi/libturborepo_ffi_windows_amd64.a(std-331aac04ffc5fa95.std.fc65e66d7b5f576c-cgu.0.rcgu.o): in function `std::sys::windows::handle::Handle::synchronous_read': cli:build: /rustc/22e9fe644ea710eec50cb0aabcae7fa8dd9fd675/library\std\src\sys\windows/handle.rs:273: undefined reference to `RtlNtStatusToDosError' cli:build: c:/programdata/chocolatey/lib/mingw/tools/install/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/11.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: D:/a/turbo/turbo/cli/internal/ffi/libturborepo_ffi_windows_amd64.a(std-331aac04ffc5fa95.std.fc65e66d7b5f576c-cgu.0.rcgu.o): in function `std::sys::windows::c::NtWriteFile': cli:build: /rustc/22e9fe644ea710eec50cb0aabcae7fa8dd9fd675/library\std\src\sys\windows/c.rs:307: undefined reference to `NtWriteFile' cli:build: c:/programdata/chocolatey/lib/mingw/tools/install/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/11.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: D:/a/turbo/turbo/cli/internal/ffi/libturborepo_ffi_windows_amd64.a(std-331aac04ffc5fa95.std.fc65e66d7b5f576c-cgu.0.rcgu.o): in function `std::sys::windows::handle::Handle::synchronous_write': cli:build: /rustc/22e9fe644ea710eec50cb0aabcae7fa8dd9fd675/library\std\src\sys\windows/handle.rs:319: undefined reference to `RtlNtStatusToDosError'

alexkirsz · 2023-07-07T12:50:24Z

Cargo.lock

@@ -5256,9 +5256,9 @@ checksum = "dc375e1527247fe1a97d8b7156678dfe7c1af2fc075c9a4db3690ecd2a148068"

 [[package]]
 name = "proc-macro2"
-version = "1.0.59"
+version = "1.0.63"


This fixes an incompatibility between proc_macro2 and newer nightlies.

github-actions · 2023-07-07T13:08:34Z

Linux Benchmark for `bc74f7b`

Click to view benchmark

Test	Base	PR	%
bench_hmr_to_commit/Turbopack CSR/1000 modules	10.09ms ± 0.10ms	10.31ms ± 0.10ms	+2.13%
bench_hmr_to_eval/Turbopack CSR/1000 modules	9829.66µs ± 109.63µs	9641.23µs ± 126.07µs	-1.92%
bench_startup/Turbopack CSR/1000 modules	1092.11ms ± 1.34ms	1092.77ms ± 5.42ms	+0.06%

github-actions · 2023-07-07T13:46:20Z

MacOS Benchmark for `bc74f7b`

Test	Base	PR	%	Significant %
bench_startup/Turbopack CSR/1000 modules	3179.39ms ± 15.97ms	3514.57ms ± 98.63ms	+10.54%	+3.30%

Click to view full benchmark

Test	Base	PR	%	Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules	27.95ms ± 0.07ms	27.63ms ± 0.29ms	-1.15%
bench_hmr_to_eval/Turbopack CSR/1000 modules	26.98ms ± 0.17ms	27.33ms ± 0.14ms	+1.30%
bench_startup/Turbopack CSR/1000 modules	3179.39ms ± 15.97ms	3514.57ms ± 98.63ms	+10.54%	+3.30%

github-actions · 2023-07-07T14:10:44Z

Linux Benchmark for `d515130`

Click to view benchmark

Test	Base	PR	%
bench_hmr_to_commit/Turbopack CSR/1000 modules	5836.81µs ± 18.58µs	5846.83µs ± 34.44µs	+0.17%
bench_hmr_to_eval/Turbopack CSR/1000 modules	5430.38µs ± 34.26µs	5551.84µs ± 116.22µs	+2.24%
bench_startup/Turbopack CSR/1000 modules	901.07ms ± 1.30ms	907.85ms ± 4.99ms	+0.75%

github-actions · 2023-07-07T14:55:37Z

MacOS Benchmark for `d515130`

Test	Base	PR	%	Significant %
bench_hmr_to_eval/Turbopack CSR/1000 modules	24.11ms ± 1.02ms	26.65ms ± 0.14ms	+10.51%	+0.78%
bench_startup/Turbopack CSR/1000 modules	10.05s ± 2.07s	3537.10ms ± 78.81ms	-64.80%	-37.38%

Click to view full benchmark

Test	Base	PR	%	Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules	28.06ms ± 0.08ms	28.25ms ± 0.10ms	+0.67%
bench_hmr_to_eval/Turbopack CSR/1000 modules	24.11ms ± 1.02ms	26.65ms ± 0.14ms	+10.51%	+0.78%
bench_startup/Turbopack CSR/1000 modules	10.05s ± 2.07s	3537.10ms ± 78.81ms	-64.80%	-37.38%

NicholasLYang

Looks good on turborepo's end!

Matching turbo PR: vercel/turbo#5376 ## Turbopack updates * vercel/turbo#5376

alexkirsz requested review from a team as code owners June 24, 2023 14:57

alexkirsz requested review from chris-olszewski and NicholasLYang June 24, 2023 14:57

turbo-orchestrator bot added team: turbopack labels Jun 24, 2023

vercel bot deployed to Preview – turbo-site June 24, 2023 14:58 View deployment

alexkirsz mentioned this pull request Jun 24, 2023

Update Rust nightly toolchain vercel/next.js#51757

Merged

alexkirsz force-pushed the alexkirsz/update-toolchain branch from aaf6a47 to 5c11cd7 Compare June 24, 2023 17:02

ForsakenHarmony reviewed Jun 24, 2023

View reviewed changes

ForsakenHarmony approved these changes Jun 24, 2023

View reviewed changes

alexkirsz force-pushed the alexkirsz/update-toolchain branch from 5c11cd7 to 0c24284 Compare June 24, 2023 18:42

alexkirsz mentioned this pull request Jun 25, 2023

[Do not merge] Small toolchain bump to check whether tests pass with older toolchain #5380

Closed

alexkirsz force-pushed the alexkirsz/update-toolchain branch from c02eb86 to 71d6caa Compare July 7, 2023 12:38

vercel bot deployed to Preview – turbo-site July 7, 2023 12:39 View deployment

alexkirsz force-pushed the alexkirsz/update-toolchain branch from 71d6caa to 2753d5f Compare July 7, 2023 12:48

alexkirsz commented Jul 7, 2023

View reviewed changes

new rust toolchain

60ddc44

Update to 2023-07-03 + Clippy + Fmt

a7d7d38

alexkirsz force-pushed the alexkirsz/update-toolchain branch from 2753d5f to a7d7d38 Compare July 7, 2023 13:50

NicholasLYang approved these changes Jul 7, 2023

View reviewed changes

alexkirsz merged commit 96254ce into main Jul 7, 2023
52 of 55 checks passed

alexkirsz deleted the alexkirsz/update-toolchain branch July 7, 2023 19:20

jridgewell pushed a commit to vercel/next.js that referenced this pull request Jul 7, 2023

Update Rust nightly toolchain (#51757)

b8589df

Matching turbo PR: vercel/turbo#5376 ## Turbopack updates * vercel/turbo#5376

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update nightly toolchain #5376

Update nightly toolchain #5376

alexkirsz commented Jun 24, 2023 •

edited

vercel bot commented Jun 24, 2023 •

edited

github-actions bot commented Jun 24, 2023 •

edited

github-actions bot commented Jun 24, 2023 •

edited

ForsakenHarmony Jun 24, 2023

github-actions bot commented Jun 24, 2023

github-actions bot commented Jun 24, 2023

alexkirsz Jul 7, 2023

alexkirsz Jul 7, 2023 •

edited

github-actions bot commented Jul 7, 2023

github-actions bot commented Jul 7, 2023

github-actions bot commented Jul 7, 2023

github-actions bot commented Jul 7, 2023

NicholasLYang left a comment

Update nightly toolchain #5376

Update nightly toolchain #5376

Conversation

alexkirsz commented Jun 24, 2023 • edited

Description

Testing Instructions

vercel bot commented Jun 24, 2023 • edited

github-actions bot commented Jun 24, 2023 • edited

github-actions bot commented Jun 24, 2023 • edited

⚠️ CI failed ⚠️

ForsakenHarmony Jun 24, 2023

Choose a reason for hiding this comment

github-actions bot commented Jun 24, 2023

Linux Benchmark for ea41f17

github-actions bot commented Jun 24, 2023

MacOS Benchmark for ea41f17

alexkirsz Jul 7, 2023

Choose a reason for hiding this comment

alexkirsz Jul 7, 2023 • edited

Choose a reason for hiding this comment

github-actions bot commented Jul 7, 2023

Linux Benchmark for bc74f7b

github-actions bot commented Jul 7, 2023

MacOS Benchmark for bc74f7b

github-actions bot commented Jul 7, 2023

Linux Benchmark for d515130

github-actions bot commented Jul 7, 2023

MacOS Benchmark for d515130

NicholasLYang left a comment

Choose a reason for hiding this comment

alexkirsz commented Jun 24, 2023 •

edited

vercel bot commented Jun 24, 2023 •

edited

github-actions bot commented Jun 24, 2023 •

edited

github-actions bot commented Jun 24, 2023 •

edited

Linux Benchmark for `ea41f17`

MacOS Benchmark for `ea41f17`

alexkirsz Jul 7, 2023 •

edited

Linux Benchmark for `bc74f7b`

MacOS Benchmark for `bc74f7b`

Linux Benchmark for `d515130`

MacOS Benchmark for `d515130`