Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Reinstate cargo sweep #5023

Merged
merged 1 commit into from
May 19, 2023
Merged

ci: Reinstate cargo sweep #5023

merged 1 commit into from
May 19, 2023

Conversation

mehulkar
Copy link
Contributor

In #4644 I had disabled cargo-sweep from running for turborepo workflows, but I implemented the if incorrectly. In #4969 I was forced to fix it, because somehow the workflow parsing was failing (although it could totally have been a red herring that it was failing on that).

I'm reinstating the cargo-sweep here because

  • I never actually removed it
  • @ForsakenHarmony had doubts about whether it was even worthwhile to remove (and again, I may have been misunderstanding what I was looking at that made me think we should remove it)

@mehulkar mehulkar marked this pull request as ready for review May 18, 2023 23:58
@mehulkar mehulkar requested review from a team as code owners May 18, 2023 23:58
@vercel
Copy link

vercel bot commented May 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
turbo-site ✅ Ready (Inspect) Visit Preview May 18, 2023 11:59pm
10 Ignored Deployments
Name Status Preview Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) May 18, 2023 11:59pm
examples-cra-web ⬜️ Ignored (Inspect) May 18, 2023 11:59pm
examples-designsystem-docs ⬜️ Ignored (Inspect) May 18, 2023 11:59pm
examples-gatsby-web ⬜️ Ignored (Inspect) May 18, 2023 11:59pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) May 18, 2023 11:59pm
examples-native-web ⬜️ Ignored (Inspect) May 18, 2023 11:59pm
examples-nonmonorepo ⬜️ Ignored (Inspect) May 18, 2023 11:59pm
examples-svelte-web ⬜️ Ignored (Inspect) May 18, 2023 11:59pm
examples-tailwind-web ⬜️ Ignored (Inspect) May 18, 2023 11:59pm
examples-vite-web ⬜️ Ignored (Inspect) May 18, 2023 11:59pm

@github-actions
Copy link
Contributor

✅ This change can build next-swc

@github-actions
Copy link
Contributor

Linux Benchmark for 110e754

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 7964.77µs ± 69.63µs 7963.46µs ± 88.01µs -0.02%
bench_hmr_to_eval/Turbopack CSR/1000 modules 7371.02µs ± 84.68µs 7446.52µs ± 662.32µs +1.02%
bench_startup/Turbopack CSR/1000 modules 861.93ms ± 2.66ms 866.62ms ± 3.94ms +0.54%

@github-actions
Copy link
Contributor

github-actions bot commented May 19, 2023

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@github-actions
Copy link
Contributor

Windows Benchmark for 110e754

Test Base PR % Significant %
bench_startup/Turbopack CSR/1000 modules 2643.90ms ± 24.03ms 2586.76ms ± 4.47ms -2.16% -0.01%
Click to view full benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 15.51ms ± 0.01ms 15.52ms ± 0.02ms +0.07%
bench_hmr_to_eval/Turbopack CSR/1000 modules 15.47ms ± 0.01ms 15.46ms ± 0.01ms -0.06%
bench_startup/Turbopack CSR/1000 modules 2643.90ms ± 24.03ms 2586.76ms ± 4.47ms -2.16% -0.01%

@mehulkar mehulkar merged commit e6532b0 into main May 19, 2023
73 of 75 checks passed
@mehulkar mehulkar deleted the mk/rm-cargo-sweep branch May 19, 2023 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants