very dynamic requests will only lead to a warning #7640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Ignored Deployments
|
🟢 Turbopack Benchmark CI successful 🟢Thanks |
|
✅ This change can build |
|
timneutkens
approved these changes
Mar 6, 2024
| let visitor = match self.ty { | ||
| DynamicExpressionType::Normal => { | ||
| create_visitor!(path, visit_mut_expr(expr: &mut Expr) { | ||
| *expr = quote!("(() => { const e = new Error(\"Cannot find module as expression is too dynamic\"); e.code = 'MODULE_NOT_FOUND'; throw e; })()" as Expr); |
There was a problem hiding this comment.
this will completely throw away information about what would have been called
can we add something back so it shows up in the stack trace?
There was a problem hiding this comment.
Giving the inline function a name would probably work
There was a problem hiding this comment.
Due to source mapping the error will point to the actual user code.
There was a problem hiding this comment.
But the stack trace still won't contain a require/import
they no longer lead to an additional module not found error
sokra
force-pushed
the
sokra/dynamic-requests-warning
branch
from
1702a06
to
c8c996d
Compare
sokra
pushed a commit
to vercel/next.js
that referenced
this pull request
Mar 7, 2024
# Turbopack * vercel/turbo#7625 <!-- Tobias Koppers - generate calls of bindings correctly without this context --> * vercel/turbo#7621 <!-- Donny/강동윤 - fix: Fix purity lint for CSS Modules in swc mode --> * vercel/turbo#7640 <!-- Tobias Koppers - very dynamic requests will only lead to a warning --> * vercel/turbo#7639 <!-- Donny/강동윤 - build: Update `swc_core` to `v0.90.17` --> ### What? Update turbopack ### Why? To keep in sync ### How?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
they no longer lead to an additional module not found error
Testing Instructions
Closes PACK-2673