Design system example is not scalable when you have many components #7529
Assignees
Labels
Comments
lorcan-codes
added
kind: bug
|
I could not upload the video here for some reason. But you can watch my demo here: https://drive.google.com/file/d/1hRToHYVyyxviHsMoBqUtgqlalLl7tnHv/view?usp=drive_link |
chris-olszewski
added
area: examples
anthonyshew
added
linear: turbo
anthonyshew
added a commit
that referenced
this issue
Mar 4, 2024
### Description As @lorcan-codes pointed out in #7529, the `design-system` example could quickly run into performance issues. This was because we were using a barrel file. I've swapped the `main` field `./packages/ui/package.json` for an `exports` field that allows for creating individual entrypoints for the package to remove this class of issue. ### Testing Instructions I verified that `turbo build && cd apps/docs && pnpm preview-storybook` runs correctly. Additionally, I made sure that `turbo dev` works and that edits to both the `Button` component itself and the story for it show hot-reloaded changes. Happy to have someone else check me! Closes TURBO-2505
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Verify canary release
Link to code that reproduces this issue
https://github.com/lorcan-codes/my-design-system
What package manager are you using / does the bug impact?
pnpm
What operating system are you using?
Mac
Which canary version will you have in your reproduction?
1.12.4
Describe the Bug
The fast refresh in docs storybook works fine when we have a few components. But it gets slower as we have more components. The system design example does not explain how we can overcome the issue.
Expected Behavior
We should not have slow refreshes even if we have many components in ui package
To Reproduce
Clone my repo:
git clone https://github.com/lorcan-codes/my-design-systempnpm iin project rootRun
pnpm devin root dir to start storybookMake some changes in button component and it takes 5-10 seconds for changes to be visible
Additional context
No response
TURBO-2503
The text was updated successfully, but these errors were encountered: