Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Remove Rust/Go toolchain for examples tests #4969

Merged
merged 1 commit into from May 17, 2023
Merged

ci: Remove Rust/Go toolchain for examples tests #4969

merged 1 commit into from May 17, 2023

Conversation

mehulkar
Copy link
Contributor

@mehulkar mehulkar commented May 16, 2023 •
edited

Examples tests do not use a local build of Turborepo, so we do not need the toolchain for that.

@vercel
Copy link

vercel bot commented May 16, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web 🔄 Building (Inspect) May 17, 2023 10:17pm
examples-tailwind-web 🔄 Building (Inspect) May 17, 2023 10:17pm
9 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-cra-web ⬜️ Ignored (Inspect) May 17, 2023 10:17pm
examples-designsystem-docs ⬜️ Ignored (Inspect) May 17, 2023 10:17pm
examples-gatsby-web ⬜️ Ignored (Inspect) May 17, 2023 10:17pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) May 17, 2023 10:17pm
examples-native-web ⬜️ Ignored (Inspect) May 17, 2023 10:17pm
examples-nonmonorepo ⬜️ Ignored (Inspect) May 17, 2023 10:17pm
examples-svelte-web ⬜️ Ignored (Inspect) May 17, 2023 10:17pm
examples-vite-web ⬜️ Ignored (Inspect) May 17, 2023 10:17pm
turbo-site ⬜️ Ignored (Inspect) Visit Preview May 17, 2023 10:17pm

@github-actions
Copy link
Contributor

✅ This change can build next-swc

@github-actions

This comment was marked as off-topic.

Sign in to view
@github-actions
Copy link
Contributor

github-actions bot commented May 16, 2023 •
edited

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@mehulkar mehulkar force-pushed the mk/examples-parallel-via-turbo branch 2 times, most recently from 219e6cf to 29f1223 Compare May 17, 2023 03:36
@mehulkar mehulkar force-pushed the mehulkar/turbo-1108-remove-turborepo-deps-for-examples-tests branch from b81bfa0 to a4b797c Compare May 17, 2023 05:56
@mehulkar mehulkar marked this pull request as ready for review May 17, 2023 06:07
@mehulkar mehulkar requested review from a team as code owners May 17, 2023 06:07
@mehulkar mehulkar requested review from nathanhammond and tknickman and removed request for a team May 17, 2023 06:07
@mehulkar mehulkar force-pushed the mehulkar/turbo-1108-remove-turborepo-deps-for-examples-tests branch from a4b797c to 262b1c6 Compare May 17, 2023 06:10
@github-actions

This comment was marked as off-topic.

Sign in to view
@github-actions

This comment was marked as off-topic.

Sign in to view
@mehulkar mehulkar changed the base branch from mk/examples-parallel-via-turbo to main May 17, 2023 07:43
@mehulkar mehulkar force-pushed the mehulkar/turbo-1108-remove-turborepo-deps-for-examples-tests branch from 262b1c6 to d9b426d Compare May 17, 2023 07:43
@github-actions

This comment was marked as off-topic.

Sign in to view
@github-actions

This comment was marked as off-topic.

Sign in to view
nathanhammond
nathanhammond reviewed May 17, 2023
View reviewed changes
.github/actions/setup-node/action.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated
node-version: 16
cache: ${{ matrix.manager }}
cache-dependency-path: package.json
run: npm i -g turbo@canary
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that our existing setup is weird and this is basically no different from our existing setup unless we make changes in the global=>local delegation.

But why would we choose to do this instead of --skip-infer and use the HEAD version directly for executing the examples?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

examples tests are testing the examples, not the cli. They don't even run when the cli source changes. They're meant to test that an out-of-box example works. This is noted in the README too: https://github.com/vercel/turbo/blob/main/turborepo-tests/examples/README.md

I agree it would be nice to utilize examples to test HEAD of cli as well, but this PR is not the thing that will get us there. (nudge: read the rfc I wrote months ago and help move it forward 😃)

@mehulkar mehulkar force-pushed the mehulkar/turbo-1108-remove-turborepo-deps-for-examples-tests branch from 874378c to cb06a3e Compare May 17, 2023 16:22
@github-actions

This comment was marked as off-topic.

Sign in to view
@mehulkar mehulkar force-pushed the mehulkar/turbo-1108-remove-turborepo-deps-for-examples-tests branch from cb06a3e to 723aa4d Compare May 17, 2023 17:07
@github-actions

This comment was marked as off-topic.

Sign in to view
@mehulkar mehulkar force-pushed the mehulkar/turbo-1108-remove-turborepo-deps-for-examples-tests branch from 723aa4d to c620266 Compare May 17, 2023 17:45
mehulkar
mehulkar commented May 17, 2023
View reviewed changes
.github/workflows/test.yml Outdated Show resolved Hide resolved
@github-actions

This comment was marked as off-topic.

Sign in to view
@github-actions

This comment was marked as off-topic.

Sign in to view
@mehulkar mehulkar force-pushed the mehulkar/turbo-1108-remove-turborepo-deps-for-examples-tests branch 2 times, most recently from 63c21bc to 25c43c2 Compare May 17, 2023 21:05
@github-actions

This comment was marked as off-topic.

Sign in to view
@mehulkar mehulkar force-pushed the mehulkar/turbo-1108-remove-turborepo-deps-for-examples-tests branch from ee29dec to a751d04 Compare May 17, 2023 21:47
@mehulkar
ci: Remove Rust/Go toolchain for examples tests
595ac6d 
Examples tests do not use a local build of Turborepo,
so we do not need the toolchain for that
@mehulkar mehulkar force-pushed the mehulkar/turbo-1108-remove-turborepo-deps-for-examples-tests branch from 6e5eb26 to 595ac6d Compare May 17, 2023 22:17
@github-actions
Copy link
Contributor

Linux Benchmark for c80f5ee

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 9325.71µs ± 61.58µs 9346.58µs ± 87.82µs +0.22%
bench_hmr_to_eval/Turbopack CSR/1000 modules 8401.76µs ± 52.95µs 8504.88µs ± 74.11µs +1.23%
bench_startup/Turbopack CSR/1000 modules 1066.07ms ± 7.34ms 1050.50ms ± 7.92ms -1.46%

@mehulkar mehulkar merged commit f89354f into main May 17, 2023
71 of 72 checks passed
@mehulkar mehulkar deleted the mehulkar/turbo-1108-remove-turborepo-deps-for-examples-tests branch May 17, 2023 22:59
@github-actions
Copy link
Contributor

MacOS Benchmark for c80f5ee

Test Base PR % Significant %
bench_hmr_to_eval/Turbopack CSR/1000 modules 24.60ms ± 0.09ms 18.96ms ± 0.71ms -22.91% -16.59%
Click to view full benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 25.34ms ± 0.08ms 25.30ms ± 0.08ms -0.14%
bench_hmr_to_eval/Turbopack CSR/1000 modules 24.60ms ± 0.09ms 18.96ms ± 0.71ms -22.91% -16.59%
bench_startup/Turbopack CSR/1000 modules 2398.44ms ± 23.67ms 2500.59ms ± 69.28ms +4.26%

@mehulkar mehulkar mentioned this pull request May 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanhammond nathanhammond nathanhammond left review comments

@tknickman tknickman tknickman approved these changes

Assignees
No one assigned
Labels
area: ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mehulkar @nathanhammond @tknickman