Skip to content

Commit

Permalink
Cleanup of with-vite example (#7585)
Browse files Browse the repository at this point in the history
### Description

- remove unused favicon.svg from both `docs` app and `web` app
- move typescript.svg to `public` directory from `src`
- changed `eslint-config-custom` to `@repo/eslint-config` in README.txt
- changed `tsconfig` to `@repo/typescript-config` in README.txt
- changed `ui` to `@repo/ui` in README.txt

### Testing Instructions

Running `npx create-turbo@latest -e with-vite` and then `pnpm dev`
should work fine and show you the vite and typescript icon in both
http://localhost:5173 and http://localhost:5174

---------

Co-authored-by: Anthony Shew <anthony.shew@vercel.com>
  • Loading branch information
zsh77 and anthonyshew committed Mar 5, 2024
1 parent dc28e67 commit d9dbbc9
Show file tree
Hide file tree
Showing 7 changed files with 5 additions and 36 deletions.
7 changes: 3 additions & 4 deletions examples/with-vite/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@ This Turborepo includes the following packages and apps:

- `docs`: a vanilla [vite](https://vitejs.dev) ts app
- `web`: another vanilla [vite](https://vitejs.dev) ts app
- `ui`: a stub component & utility library shared by both `web` and `docs` applications
- `eslint-config-custom`: shared `eslint` configurations
- `tsconfig`: `tsconfig.json`s used throughout the monorepo
- `@repo/ui`: a stub component & utility library shared by both `web` and `docs` applications
- `@repo/eslint-config`: shared `eslint` configurations
- `@repo/typescript-config`: `tsconfig.json`s used throughout the monorepo

Each package and app is 100% [TypeScript](https://www.typescriptlang.org/).

Expand All @@ -30,5 +30,4 @@ This Turborepo has some additional tools already setup for you:

- [TypeScript](https://www.typescriptlang.org/) for static type checking
- [ESLint](https://eslint.org/) for code linting
- [Jest](https://jestjs.io) test runner for all things JavaScript
- [Prettier](https://prettier.io) for code formatting
15 changes: 0 additions & 15 deletions examples/with-vite/apps/docs/favicon.svg

This file was deleted.

2 changes: 1 addition & 1 deletion examples/with-vite/apps/docs/src/main.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { Header } from "@repo/ui/header";
import "./style.css";
import typescriptLogo from "./typescript.svg";
import typescriptLogo from "/typescript.svg";
import { Counter } from "@repo/ui/counter";
import { setupCounter } from "@repo/ui/setup-counter";

Expand Down
15 changes: 0 additions & 15 deletions examples/with-vite/apps/web/favicon.svg

This file was deleted.

2 changes: 1 addition & 1 deletion examples/with-vite/apps/web/src/main.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { Header } from "@repo/ui/header";
import "./style.css";
import typescriptLogo from "./typescript.svg";
import typescriptLogo from "/typescript.svg";
import { Counter } from "@repo/ui/counter";
import { setupCounter } from "@repo/ui/setup-counter";

Expand Down

0 comments on commit d9dbbc9

Please sign in to comment.