Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: correctly call teams api (#7533)
### Description I was getting the following error ``` [0 olszewski@chriss-mbp] /Users/olszewski/code/vercel/turborepo $ turbo_dev logout >>> Logged out [0 olszewski@chriss-mbp] /Users/olszewski/code/vercel/turborepo $ turbo_dev login --sso-team=vercel × Error making HTTP request: HTTP status server error (508 Loop Detected) for url (https://vercel.com/api/v2/team?teamId=vercel) ╰─▶ HTTP status server error (508 Loop Detected) for url (https://vercel.com/api/v2/team?teamId=vercel) ``` Checking the [docs](https://vercel.com/docs/rest-api/endpoints/teams#get-a-team) we're hitting a non-existent endpoint and incorrectly passing path parameters as query parameters. This PR fixes our `get_team` API usage. Note: this does not fix other issues with the Vercel token workflow as `turbo link` and `turbo run` don't use it so users can get in states where `turbo login` will claim you're logged in, but trying `turbo link` will fail as there isn't a token found. ### Testing Instructions In order to hit this codepath you need to be in the correct state of having a Vercel token, but not a Turbo token. Setup: ``` [0 olszewski@chriss-mbp] /Users/olszewski/code/vercel/turborepo $ turbo logout >>> Logged out [0 olszewski@chriss-mbp] /Users/olszewski/code/vercel/turborepo $ vc login Vercel CLI 29.3.0 ? Log in to Vercel saml ? Enter your Team slug: vercel > Success! SAML Single Sign-On authentication complete for chris.olszewski@vercel.com Congratulations! You are now logged in. In order to deploy something, run `vercel`. 💡 Connect your Git Repositories to deploy every branch push automatically (https://vercel.link/git). ``` Testing: ``` # on main [0 olszewski@chriss-mbp] /Users/olszewski/code/vercel/turborepo $ turbo_dev login --sso-team=vercel × Error making HTTP request: HTTP status server error (508 Loop Detected) for url (https://vercel.com/api/v2/team?teamId=vercel) ╰─▶ HTTP status server error (508 Loop Detected) for url (https://vercel.com/api/v2/team?teamId=vercel) # Checkout PR and rebuild [0 olszewski@chriss-mbp] /Users/olszewski/code/vercel/turborepo $ git co olszewski/fix_usage_of_vercel_token [0 olszewski@chriss-mbp] /Users/olszewski/code/vercel/turborepo $ cargo build -p turbo ... # Try to login again [0 olszewski@chriss-mbp] /Users/olszewski/code/vercel/turborepo $ turbo_dev login --sso-team=vercel Existing Vercel token found! >>> Success! Turborepo CLI authorized for chris.olszewski@vercel.com To connect to your Remote Cache, run the following in any turborepo: npx turbo link ``` Closes TURBO-2453
- Loading branch information