Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Make use of Suspense conditional #65766

Draft
wants to merge 2 commits into
base: canary
Choose a base branch
from

Conversation

snehakhobragade90
Copy link

@snehakhobragade90 snehakhobragade90 commented May 14, 2024

Fixing a bug

What?

Extra Suspense boundary flashes the loading state for the next/dynamic components. For SSR, it shouldn't render loading by default. This was earlier fixed in the PR but reverted later as removing this led of the server side errors to bubble up leading the pages to crash.

This draft proposes to add this Suspense conditionally. The consumers can add a suspense within their client if they want to avoid the server-side errors to bubble up instead of the framework doing it mandatorily.

Fixes #64060 #64687

@ijjk
Copy link
Member

ijjk commented May 14, 2024

Allow CI Workflow Run

  • approve CI run for commit: c498779

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@ijjk
Copy link
Member

ijjk commented May 14, 2024

Allow CI Workflow Run

  • approve CI run for commit: a1d2296

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App router: Content flickering with React.createContext and next/dynamic for SSG/SSR
2 participants