Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update swc_core to v0.90.21 #63031

Merged
merged 7 commits into from
Mar 13, 2024
Merged

chore: Update swc_core to v0.90.21 #63031

merged 7 commits into from
Mar 13, 2024

Conversation

@kdy1 kdy1 self-assigned this Mar 8, 2024
@kdy1 kdy1 requested review from timneutkens, ijjk, shuding, huozhi and a team as code owners March 8, 2024 05:54
@ijjk ijjk added the created-by: Turbopack team PRs by the turbopack team label Mar 8, 2024
@kdy1 kdy1 marked this pull request as draft March 8, 2024 05:54
@ijjk ijjk added the type: next label Mar 8, 2024
@kdy1 kdy1 marked this pull request as ready for review March 8, 2024 05:55
@ijjk
Copy link
Member

ijjk commented Mar 8, 2024

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js kdy1/swc-core-0-90-6 Change
buildDuration 13.7s 13.7s N/A
buildDurationCached 7.3s 6.3s N/A
nodeModulesSize 198 MB 198 MB
nextStartRea..uration (ms) 417ms 444ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js kdy1/swc-core-0-90-6 Change
2453-HASH.js gzip 30.4 kB 30.4 kB N/A
3304.HASH.js gzip 181 B 181 B
3f784ff6-HASH.js gzip 53.7 kB 53.7 kB N/A
8299-HASH.js gzip 5.04 kB 5.04 kB N/A
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 242 B 241 B N/A
main-HASH.js gzip 32.2 kB 32.2 kB N/A
webpack-HASH.js gzip 1.68 kB 1.68 kB N/A
Overall change 45.4 kB 45.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js kdy1/swc-core-0-90-6 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js kdy1/swc-core-0-90-6 Change
_app-HASH.js gzip 196 B 197 B N/A
_error-HASH.js gzip 184 B 184 B
amp-HASH.js gzip 505 B 505 B
css-HASH.js gzip 324 B 325 B N/A
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 258 B 258 B
head-HASH.js gzip 352 B 352 B
hooks-HASH.js gzip 370 B 371 B N/A
image-HASH.js gzip 4.21 kB 4.21 kB
index-HASH.js gzip 259 B 259 B
link-HASH.js gzip 2.67 kB 2.67 kB N/A
routerDirect..HASH.js gzip 314 B 312 B N/A
script-HASH.js gzip 386 B 386 B
withRouter-HASH.js gzip 309 B 309 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 6.57 kB 6.57 kB
Client Build Manifests
vercel/next.js canary vercel/next.js kdy1/swc-core-0-90-6 Change
_buildManifest.js gzip 481 B 484 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js kdy1/swc-core-0-90-6 Change
index.html gzip 528 B 530 B N/A
link.html gzip 541 B 542 B N/A
withRouter.html gzip 524 B 524 B
Overall change 524 B 524 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js kdy1/swc-core-0-90-6 Change
edge-ssr.js gzip 95.1 kB 95.1 kB N/A
page.js gzip 3.07 kB 3.07 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js kdy1/swc-core-0-90-6 Change
middleware-b..fest.js gzip 626 B 624 B N/A
middleware-r..fest.js gzip 151 B 151 B
middleware.js gzip 25.5 kB 25.5 kB N/A
edge-runtime..pack.js gzip 839 B 839 B
Overall change 990 B 990 B
Next Runtimes
vercel/next.js canary vercel/next.js kdy1/swc-core-0-90-6 Change
app-page-exp...dev.js gzip 171 kB 171 kB
app-page-exp..prod.js gzip 96.6 kB 96.6 kB
app-page-tur..prod.js gzip 98.3 kB 98.3 kB
app-page-tur..prod.js gzip 92.8 kB 92.8 kB
app-page.run...dev.js gzip 149 kB 149 kB
app-page.run..prod.js gzip 91.3 kB 91.3 kB
app-route-ex...dev.js gzip 21.3 kB 21.3 kB
app-route-ex..prod.js gzip 15 kB 15 kB
app-route-tu..prod.js gzip 15 kB 15 kB
app-route-tu..prod.js gzip 14.8 kB 14.8 kB
app-route.ru...dev.js gzip 21 kB 21 kB
app-route.ru..prod.js gzip 14.8 kB 14.8 kB
pages-api-tu..prod.js gzip 9.52 kB 9.52 kB
pages-api.ru...dev.js gzip 9.8 kB 9.8 kB
pages-api.ru..prod.js gzip 9.52 kB 9.52 kB
pages-turbo...prod.js gzip 22.3 kB 22.3 kB
pages.runtim...dev.js gzip 22.9 kB 22.9 kB
pages.runtim..prod.js gzip 22.3 kB 22.3 kB
server.runti..prod.js gzip 50.5 kB 50.5 kB
Overall change 948 kB 948 kB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js kdy1/swc-core-0-90-6 Change
0.pack gzip 1.55 MB 1.56 MB ⚠️ +2.57 kB
index.pack gzip 105 kB 105 kB ⚠️ +121 B
Overall change 1.66 MB 1.66 MB ⚠️ +2.69 kB
Diff details
Diff for middleware.js

Diff too large to display

Commit: f231c40

@kdy1 kdy1 marked this pull request as draft March 12, 2024 06:42
@kdy1 kdy1 changed the title chore: Update swc_core to v0.90.18 chore: Update swc_core to v0.90.19 Mar 12, 2024
@ijjk
Copy link
Member

ijjk commented Mar 12, 2024

Failing test suites

Commit: 8f84ec2

TURBOPACK=1 pnpm test-dev test/e2e/prerender.test.ts (turbopack)

  • Prerender > should handle fallback only page correctly HTML
Expand output

● Prerender › should handle fallback only page correctly HTML

expect(received).toContain(expected) // indexOf

Expected substring: "hi fallback"
Received string:    "Post: first/post"

  849 |
  850 |       const text = await browser.elementByCss('p').text()
> 851 |       expect(text).toContain('hi fallback')
      |                    ^
  852 |
  853 |       // wait for fallback data to load
  854 |       await check(() => browser.elementByCss('p').text(), /Post/)

  at Object.toContain (e2e/prerender.test.ts:851:20)

Read more about building and testing Next.js in contributing.md.

@kdy1 kdy1 changed the title chore: Update swc_core to v0.90.19 chore: Update swc_core to v0.90.21 Mar 13, 2024
@sokra sokra marked this pull request as ready for review March 13, 2024 16:10
@sokra sokra requested review from a team, feedthejim, ztanner and wyattjoh as code owners March 13, 2024 16:10
@sokra sokra enabled auto-merge (squash) March 13, 2024 17:03
@sokra sokra merged commit 013ba06 into canary Mar 13, 2024
68 checks passed
@sokra sokra deleted the kdy1/swc-core-0-90-6 branch March 13, 2024 17:11
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants