Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase timeout for 404 tests #52998

Merged
merged 1 commit into from
Jul 21, 2023
Merged

Increase timeout for 404 tests #52998

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...s/next-swc/crates/next-dev-tests/tests/integration/next/app/404-custom/input/app/test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ export default function Test() {
function runTests(harness: Harness, iframe: HTMLIFrameElement) {
// These tests requires a longer timeout because we're rendering the 404 page as well.
const TIMEOUT = 20000
const LONG_TIMEOUT = 60000

it(
'returns a 404 status code for the custom 404 page',
Expand Down Expand Up @@ -60,13 +61,14 @@ function runTests(harness: Harness, iframe: HTMLIFrameElement) {
TIMEOUT
)

// TODO: This test is flaky, so it needs a particularly long timeout.
it(
'returns a 404 status code for a segment 404 page',
async () => {
const res = await fetch('/segment')
expect(res.status).toBe(404)
},
TIMEOUT
LONG_TIMEOUT
)

// TODO(WEB-980) Fix this test once we no longer throw an error when rendering a 404 page.
Expand Down