Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(next/image): washed out blur placeholder #52583
fix(next/image): washed out blur placeholder #52583
Changes from 21 commits
bd03f45
72e0bc2
de61d58
4038a82
09d3b7b
15e2ca8
13797e2
968c04c
acd08c0
a3f9fa3
84d3ba9
8f4a83e
4eedbe0
6822c0d
9279f5c
69eddac
8757bc2
5190c57
ecec9e1
a40f6aa
f8cbf8e
ce55dfd
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Magic number why 20? Also we should consider renaming std, what is it short for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah "std" was supposed to stand for "standard deviation" but I agree that it sounds bad now that I think about it 😂
It should be renamed to "blur".
And the blur value is set to 20 because it looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you change the order of the props so that the diff is easier to review?
Lets keep it: style, preserveAspectRatio, x, y, height, width, href
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@styfle We should probably rename this test or at least add some comment explaining the viewBox multiplier 8 * 40 = 320. Any suggestions?
Maybe
should scale generated blur placeholder by 40
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I think the name is correct because the
8
is referring about the inputw
.