Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Pages API rendering into bundle #52149
Move Pages API rendering into bundle #52149
Changes from 19 commits
db61ef2
2e76cdf
9115852
9ba9810
d4293d8
5a237a7
4889600
f0d4525
6e04025
2848ce5
d681831
750c776
a5fb25d
850b7cc
7dff5b8
31941d3
90f3fc7
989dd95
ef8255d
c0576dc
642bc57
647187c
041cd60
8cc3eeb
e8b2319
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of copying the code for turbopack and webpack, you can put that code into a shared JS file.
This can be imported in turobpack, and a webpack can read the file and replace
"INNER"
with string replaceThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we put this into a JS file, we can't perform the following:
next.js/packages/next-swc/crates/next-build/src/next_pages/page_entries.rs
Lines 386 to 394 in ef8255d
Or
next.js/packages/next/src/build/webpack/loaders/next-route-loader/index.ts
Lines 129 to 136 in 503677c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reading the file from disk will give us a
RopeVc
, which we can then use to build another rope that we can concatenate into.