Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restrict useOptimistic and useFormStatus APIs on the server layer #49331

Merged
merged 1 commit into from
May 8, 2023
Merged

Restrict useOptimistic and useFormStatus APIs on the server layer #49331

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/next-swc/crates/core/src/react_server_components.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -572,6 +572,8 @@ pub fn server_components<C: Comments>(
JsWord::from("findDOMNode"),
JsWord::from("flushSync"),
JsWord::from("unstable_batchedUpdates"),
JsWord::from("experimental_useFormStatus"),
JsWord::from("experimental_useOptimistic"),
],
invalid_server_react_apis: vec![
JsWord::from("Component"),
Expand Down
5 changes: 5 additions & 0 deletions ...-swc/crates/core/tests/errors/react-server-components/server-graph/react-dom-api/input.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
import { findDOMNode, flushSync, unstable_batchedUpdates } from 'react-dom'

import {
experimental_useOptimistic as useOptimistic,
experimental_useFormStatus,
} from 'react-dom'

export default function () {
return null
}
1 change: 1 addition & 0 deletions ...swc/crates/core/tests/errors/react-server-components/server-graph/react-dom-api/output.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { findDOMNode, flushSync, unstable_batchedUpdates } from 'react-dom';
import { experimental_useOptimistic as useOptimistic, experimental_useFormStatus } from 'react-dom';
export default function() {
return null;
}
16 changes: 16 additions & 0 deletions ...crates/core/tests/errors/react-server-components/server-graph/react-dom-api/output.stderr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,3 +16,19 @@
1 | import { findDOMNode, flushSync, unstable_batchedUpdates } from 'react-dom'
: ^^^^^^^^^^^^^^^^^^^^^^^
`----

x NEXT_RSC_ERR_REACT_API: experimental_useOptimistic
,-[input.js:3:1]
3 | import {
4 | experimental_useOptimistic as useOptimistic,
: ^^^^^^^^^^^^^^^^^^^^^^^^^^
5 | experimental_useFormStatus,
`----

x NEXT_RSC_ERR_REACT_API: experimental_useFormStatus
,-[input.js:4:1]
4 | experimental_useOptimistic as useOptimistic,
5 | experimental_useFormStatus,
: ^^^^^^^^^^^^^^^^^^^^^^^^^^
6 | } from 'react-dom'
`----