Skip to content

Commit

Permalink
chore(test): fix flaky tsconfig.json test (#53132)
Browse files Browse the repository at this point in the history
This test was [sometimes failing](

https://github.com/vercel/next.js/actions/runs/5649220907/job/15303327768?pr=53130#step:27:230)
because the `tsconfig.json` is [written as an empty
object](https://github.com/vercel/next.js/blob/a26bac96048c7231271b5947eaf80241e94ca2fc/packages/next/src/lib/typescript/writeConfigurationDefaults.ts#L123-L125).

This PR makes sure the test waits until the tsconfig.json file is
written with the complete contents.
  • Loading branch information
styfle committed Jul 24, 2023
1 parent d8f4fa8 commit 8dede2a
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions test/development/correct-tsconfig-defaults/index.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,13 +28,14 @@ describe('correct tsconfig.json defaults', () => {

await next.start()

let content: string
// wait for tsconfig to be written
await check(async () => {
await next.readFile('tsconfig.json')
return 'success'
}, 'success')
content = await next.readFile('tsconfig.json')
return content && content !== '{}' ? 'ready' : 'retry'
}, 'ready')

const tsconfig = JSON.parse(await next.readFile('tsconfig.json'))
const tsconfig = JSON.parse(content)
expect(next.cliOutput).not.toContain('moduleResolution')

expect(tsconfig.compilerOptions).toEqual(
Expand Down

0 comments on commit 8dede2a

Please sign in to comment.