Skip to content

Commit

Permalink
chore(ci): fix turbo input path globs (#52414)
Browse files Browse the repository at this point in the history
This PR fixes turbo.json inputs to avoid cache hit when it should be cache miss.

Example PR it was incorrectly cached:

- [PR 52407](#52407)
- [Commit 06b780](06b780e)
- [Logs with cache hit](https://github.com/vercel/next.js/actions/runs/5488474758/jobs/10001427837#step:27:29)

The docs mention the glob is relative to the workspace (aka package) directory, not the monorepo root.

> inputs globs must be specified as relative paths rooted at the workspace directory.

https://turbo.build/repo/docs/reference/configuration#inputs
  • Loading branch information
styfle committed Jul 8, 2023
1 parent 9ccc6fc commit 0abc874
Showing 1 changed file with 17 additions and 17 deletions.
34 changes: 17 additions & 17 deletions turbo.json
Original file line number Diff line number Diff line change
Expand Up @@ -41,35 +41,35 @@
"//#typescript": {},
"rust-check": {
"inputs": [
".cargo/**",
"packages/next-swc/crates/**",
"**/Cargo.toml",
"**/Cargo.lock"
"../../.cargo/**",
"../../packages/next-swc/crates/**",
"../../**/Cargo.toml",
"../../**/Cargo.lock"
]
},
"test-cargo-unit": {
"inputs": [
".cargo/**",
"packages/next-swc/crates/**",
"**/Cargo.toml",
"**/Cargo.lock"
"../../.cargo/**",
"../../packages/next-swc/crates/**",
"../../**/Cargo.toml",
"../../**/Cargo.lock"
]
},
"test-cargo-integration": {
"inputs": [
".cargo/**",
"packages/next-swc/crates/**",
"packages/next/**",
"**/Cargo.toml",
"**/Cargo.lock"
"../../.cargo/**",
"../../packages/next-swc/crates/**",
"../../packages/next/**",
"../../**/Cargo.toml",
"../../**/Cargo.lock"
]
},
"test-cargo-bench": {
"inputs": [
".cargo/**",
"packages/next-swc/crates/**",
"**/Cargo.toml",
"**/Cargo.lock"
"../../.cargo/**",
"../../packages/next-swc/crates/**",
"../../**/Cargo.toml",
"../../**/Cargo.lock"
]
},
"//#get-test-timings": {
Expand Down

0 comments on commit 0abc874

Please sign in to comment.