Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate documentation from Relishapp to Github page #968

Open
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

benoittgt
Copy link

@benoittgt benoittgt commented Mar 10, 2023

Recently Relishapp was sadly broken. It is not possible to make it easily work again.

To let user access to a new documentation I tried to migrate all documentation to Github page.
Tasks done in this PR:

  • Generate markdown from .feature file using https://github.com/raviqqe/gherkin2markdown
  • Serve them using docsify
  • Properly generate sidebar with a custom script
  • Provide a script to easily generate documentation
  • Reformat some part of the features files for better display in markdown format

A demo with this code can be seen here: https://benoittgt.github.io/vcr/#/

Screenshot 2023-03-10 at 23 54 29

Screenshot 2023-03-10 at 23 53 34

There is still tasks that should be addressed. See list here: #967 (comment). But I think we should already offer a documentation.

Sorry for the not super well commit story.

Close: #967

@benoittgt benoittgt marked this pull request as ready for review March 10, 2023 22:56
@Fryguy
Copy link

Fryguy commented Mar 11, 2023

These look beautiful. Thank you for taking this on.

@benoittgt
Copy link
Author

We will have to change link in command output too.

@olleolleolle
Copy link
Member

olleolleolle commented Mar 21, 2023

We will have to change link in command output too.

Right, these:

"https://www.relishapp.com/vcr/vcr/v/%s/docs/record-modes/new-episodes"

With a link like

https://benoittgt.github.io/vcr/#/record_modes/new_episodes?id=new_episodes

...since I can't seem to locate any "version-specific docs" link there.

@benoittgt
Copy link
Author

I need to do extra work for the version. I will see what I can do.

@olleolleolle
Copy link
Member

@benoittgt At any rate, people will have to upgrade to new code to enjoy the new links, anyway, so no rush.

@olleolleolle
Copy link
Member

@benoittgt As an update, I have merged #973 which uses the benoittgt GitHub Pages site for docs, in the RubyGems metadata section for homepage, which will be reflected on that site with the next release.

@benoittgt
Copy link
Author

Ok thanks ! To accept this current PR we want to have the version switcher? Anything else? :)

@olleolleolle
Copy link
Member

@benoittgt I think we are amazing if we have a version switcher.

jmpage added a commit to jmpage/vcr that referenced this pull request Jun 17, 2023
The rubygems homepage was updated to point to the in-development docs in vcr#973.

This PR updates the readme to also point to the in-development docsite in the interim while vcr#968 is still under development.
@jmpage
Copy link
Contributor

jmpage commented Jun 17, 2023

@olleolleolle I'm sorry to jump in out of the blue, but would this be worth merging on the basis of "perfect is the enemy of done," after which a version switcher could be added?

I have personally found the new documentation site to be very helpful, especially compared to the unfortunately dead relishapp docs.

olleolleolle pushed a commit that referenced this pull request Jun 18, 2023
The rubygems homepage was updated to point to the in-development docs in #973.

This PR updates the readme to also point to the in-development docsite in the interim while #968 is still under development.
@benoittgt
Copy link
Author

For the version switcher. There is a nice proposal on this repository with the result.

It is a little bit detailed in an article.

I started looking at it, but it requires some work. And probably we need to create "stable" branch OR limit the documentation per tag. If we want something more dynamic, we need to follow imgproxy code.

@olleolleolle
Copy link
Member

@benoittgt ❤️❤️❤️ That's fantastic!

@olleolleolle
Copy link
Member

@benoittgt I dropped Ruby 2.6 from CI and gemspec, now, so if you rebase, we ought to be green.

@olleolleolle
Copy link
Member

olleolleolle commented Jun 26, 2023

https://github.com/vcr/vcr/blob/master/Rakefile#L33 This code still exists, and I guess could get some automation love.

@benoittgt None of those scripts are in use, right? I ought to be able to remove them, no replacement.

EDIT: Update - we no longer have those Rake tasks or Relish app code around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Documentation Website (née #755)
4 participants