Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add drop_unused_requests option to exclude unused interactions #946

Merged
merged 3 commits into from Oct 18, 2022
Merged

Add drop_unused_requests option to exclude unused interactions #946

merged 3 commits into from Oct 18, 2022

Conversation

ryanseys
Copy link
Contributor

This is a rebase of #769 so that we can hopefully merge it! :)

@ryanseys ryanseys marked this pull request as ready for review September 21, 2022 00:20
This was referenced Sep 21, 2022
Closed
Closed
@umerakram1
Copy link

Review

@olleolleolle
Copy link
Member

(Ran the tests and recorded #948.)

olleolleolle
olleolleolle previously approved these changes Oct 11, 2022
View reviewed changes
Copy link
Member

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this change, and seems to do what it sets out to do.

(One thing we often ask is "How do we teach this?", and perhaps that's a further question, for later. But this is a new configuration option, and its place is in the user-visible documentation, in some form.)

The test failures in the cucumber tests have been reported separately.

spec/lib/vcr/cassette_spec.rb Show resolved Hide resolved
spec/lib/vcr/cassette_spec.rb Show resolved Hide resolved
spec/lib/vcr/cassette_spec.rb Show resolved Hide resolved
@ryanseys ryanseys mentioned this pull request Oct 14, 2022
Merged
@ryanseys
Copy link
Contributor Author

Fix for curb issue here: #949

@ryanseys
Copy link
Contributor Author

Depends on (and is rebased on) this PR, which we should merge first: #949

@ryanseys
Copy link
Contributor Author

@olleolleolle

But this is a new configuration option, and its place is in the user-visible documentation, in some form.

I've added feature documentation in bf38ee2 (#946)

@olleolleolle
Copy link
Member

olleolleolle commented Oct 14, 2022 •
edited

@ryanseys Cool, now with the other PR merged, we could re-run the tests, and that gave just one failure, which seems like a fixable one. Good job!

(I'll wait for you to make that pass.)

mhuntglickman and others added 2 commits October 14, 2022 08:32
@mhuntglickman @ryanseys
PR vcr#746 New record Mode option re_record
04ee25a
@ryanseys @olleolleolle
Fixed formatting
c611137 
Co-authored-by: Olle Jonsson <olle.jonsson@gmail.com>
@ryanseys
Copy link
Contributor Author

@olleolleolle Should be passing now. Please take another look.

olleolleolle
olleolleolle approved these changes Oct 18, 2022
View reviewed changes
Copy link
Member

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@olleolleolle olleolleolle merged commit 93ae14e into vcr:master Oct 18, 2022
olleolleolle added a commit that referenced this pull request Oct 18, 2022
@olleolleolle
CHANGELOG: add #946 to "Unreleased" [ci skip]
84e5040
@ryanseys ryanseys mentioned this pull request Oct 19, 2022
Closed
@danielnsilva danielnsilva mentioned this pull request Jan 4, 2023
Closed
@klyonrad
Copy link

@olleolleolle any chance for an official release of this feature? I tried it briefly and seemd quite awesome!

@olleolleolle
Copy link
Member

@klyonrad You may try the new 6.2.0 release at your leisure.

@danielnsilva danielnsilva mentioned this pull request Aug 20, 2023
Open
@ryanseys ryanseys deleted the drop-unused-requests branch September 29, 2023 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olleolleolle olleolleolle olleolleolle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ryanseys @umerakram1 @olleolleolle @klyonrad @mhuntglickman