Clarify faraday's on_data callback tests #933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Easier to spot
Clarify that we have to pass on_data callback to request
|
👋 Very interested in contributions that clarify tests! Thanks for all this, I'll get to reading it real soon! 💯 |
olleolleolle
approved these changes
Apr 19, 2022
There was a problem hiding this comment.
We are now checking what is yielded in a clearer way, and are explaining make_request taking a block clearer.
Thanks, @nellirx!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey folks,
just curious if you would be interested in such contributions
I'd appreciate any feedback please :)
Thank you!