Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert unnecessary command behavior change #197

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Revert unnecessary command behavior change #197

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 6 additions & 3 deletions Sources/ConsoleKitCommands/Base/AnyCommand.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,12 @@ extension AnyCommand {
""
}

// we need to have a sync environment so the compiler uses the sync run method over the async version
private func syncRun(using context: inout CommandContext) throws {
try self.run(using: &context)
}

public func run(using context: inout CommandContext) async throws {
try await withCheckedThrowingContinuation { continuation in
continuation.resume(with: .init { try self.run(using: &context) })
}
try self.syncRun(using: &context)
}
}