vite
: Don't pass through plugins by default, add unstable_pluginFilter
option
#1537
+75
−19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1524. Fixes #1506. Fixes #1403. Fixes #1408. Fixes #1454.
Technically also fixes both #1453 and #1519, but they'll get fixed by #1535.
Forwarding plugins through to the compiler tends to cause more issues than it solves. Numerous code changes have already been made to address issues caused by some plugins. E.g. #1308, #1492, #1369, #1300, #1264, and likely others.
Changes in this PR:
vite-tsconfig-paths
as we know it's compatible, and we have tests for it. This is a breaking change, but I don't think it will cause that many breakages, and may in fact fix more issues than it causes.unstable_pluginFilter
option if they need to pass through plugins to the compiler (hopefully the majority of users will not need to do this)I've chosen not to document
unstable_pluginFilter
just yet as it is unstable API and may change.Additionally, the plugin has been renamed to
vite-plugin-vanilla-extract
as this better aligns with the vite plugin conventions.