Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor update to comments and .md files #58

Merged
merged 2 commits into from
May 4, 2023

Conversation

DrShushen
Copy link
Member

@DrShushen DrShushen commented May 3, 2023

UPDATE: requests v2.30.0 yanked, the pin no longer necessary. PR will be merged to include minor update in md files/comments

Description

This is a hotfix to avoid a bug with truncated responses with requests v2.30.0 & urllib3 v2, see:

For now, pin dependency urllib3<2 as this resolves the problem:

Affected Dependencies

N/A

How has this been tested?

N/A

Checklist

@DrShushen DrShushen self-assigned this May 3, 2023
@DrShushen DrShushen added the bug Something isn't working label May 3, 2023
@DrShushen DrShushen changed the title Upd reqs to avoid bug w requests 2.30 & urllib3 2 Hotfix to avoid bug with requests v2.30.0 & urllib3 v2 May 3, 2023
@DrShushen DrShushen requested a review from robsdavis May 3, 2023 17:33
@DrShushen
Copy link
Member Author

With this change, the "Tests Full" workflow should pass. Will merge once that is confirmed.

@codecov
Copy link

codecov bot commented May 3, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.14 🎉

Comparison is base (bfae0aa) 89.51% compared to head (4d3558a) 89.65%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #58      +/-   ##
==========================================
+ Coverage   89.51%   89.65%   +0.14%     
==========================================
  Files         101      101              
  Lines        5559     5559              
  Branches      665      665              
==========================================
+ Hits         4976     4984       +8     
+ Misses        409      401       -8     
  Partials      174      174              
Flag Coverage Δ
test 89.51% <ø> (ø)
test_full 89.65% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pquentin
Copy link

pquentin commented May 3, 2023

Thank you for the report, @DrShushen! requests 2.30.0 was just yanked, so you don't have to pin: https://pypi.org/project/requests/2.30.0/. I would expect 2.30.1 to come out when the bug is fixed.

@DrShushen
Copy link
Member Author

DrShushen commented May 3, 2023

Removed the pin, will merge PR to minor README fix

@DrShushen
Copy link
Member Author

@DrShushen DrShushen changed the title Hotfix to avoid bug with requests v2.30.0 & urllib3 v2 Minor update to comments and .md files May 3, 2023
@DrShushen DrShushen merged commit 06c280f into main May 4, 2023
29 checks passed
@DrShushen DrShushen deleted the DrShushen/fix-pandas-eof-fail branch May 4, 2023 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants