Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): update fastlane #4204

Merged
merged 2 commits into from
Sep 18, 2023
Merged

fix(ci): update fastlane #4204

merged 2 commits into from
Sep 18, 2023

Conversation

jeanregisser
Copy link
Member

@jeanregisser jeanregisser commented Sep 18, 2023

Description

This updates fastlane to workaround the following error while uploading to the Play Store:

[08:03:25]: Google Api Error: Unauthorized - Request is missing required authentication credential. Expected OAuth 2 access token, login cookie or other valid authentication credential. See https://developers.google.com/identity/sign-in/web/devconsole-project.

See fastlane/fastlane#21518

See related https://github.com/valora-inc/release-automation/pull/57

Test plan

Triggering a run from the nightly workflow against the custom branch was successful: https://github.com/valora-inc/release-automation/actions/runs/6221137351
However it seems it didn't hit the API error that time and didn't have to retry.
We'll keep an eye on this.

Related issues

Backwards compatibility

Yes

@jeanregisser jeanregisser changed the title chore(ci): update fastlane fix(ci): update fastlane Sep 18, 2023
@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #4204 (f814dc9) into main (9667e35) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4204      +/-   ##
==========================================
- Coverage   83.68%   83.67%   -0.02%     
==========================================
  Files         721      721              
  Lines       26317    26317              
  Branches     3385     3385              
==========================================
- Hits        22023    22020       -3     
- Misses       4227     4230       +3     
  Partials       67       67              

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9667e35...f814dc9. Read the comment docs.

@jeanregisser jeanregisser merged commit 2062dd5 into main Sep 18, 2023
15 checks passed
@jeanregisser jeanregisser deleted the jeanregisser/upgrade-fastlane branch September 18, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants