Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(isMobilePhone): fixed es-CU matching all numbers that start with 5 longer than 8 digits #2197

Merged
merged 1 commit into from Mar 7, 2023

Conversation

klaframboise
Copy link
Contributor

fixes #2196

This MR fixes the es-CU locale isMobilePhone regex by adding the missing end of line matcher.

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)
  • References provided in PR (where applicable)

@codecov
Copy link

codecov bot commented Mar 3, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (43803c0) 100.00% compared to head (0871157) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #2197   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          106       106           
  Lines         2348      2348           
  Branches       593       593           
=========================================
  Hits          2348      2348           
Impacted Files Coverage Δ
src/lib/isMobilePhone.js 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

@profnandaa profnandaa merged commit cb91971 into validatorjs:master Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

isMobilePhone with locale es-CU matches numbers of any length > 8 when the number starts with 5
2 participants