Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(isMobilePhone): Add Central African Republic Locale And Prefix(CF) #2176

Merged
merged 1 commit into from
Feb 8, 2023
Merged

feat(isMobilePhone): Add Central African Republic Locale And Prefix(CF) #2176

merged 1 commit into from
Feb 8, 2023

Conversation

cheboi
Copy link
Contributor

@cheboi cheboi commented Feb 3, 2023

added validation and test for isMobilePhone code Locale for Central African Republic (CF).
reference doc:
https://www.wikiwand.com/en/Telephone_numbers_in_the_Central_African_Republic
https://freetools.textmagic.com/phone-validator

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@codecov
Copy link

codecov bot commented Feb 3, 2023

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (1138a0f) compared to base (54d330c).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@            Coverage Diff            @@
##            master     #2176   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          105       105           
  Lines         2324      2324           
  Branches       586       586           
=========================================
  Hits          2324      2324
Impacted Files Coverage Δ
src/lib/isMobilePhone.js 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rubiin rubiin added the ✅ LGTM label Feb 4, 2023
ezkemboi
ezkemboi requested changes Feb 6, 2023
View reviewed changes
Copy link
Member

@ezkemboi ezkemboi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add details to README.md

profnandaa
profnandaa approved these changes Feb 8, 2023
View reviewed changes
Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging, will update the README manually, to avoid potential merge conflicts.

@profnandaa profnandaa merged commit 7cda875 into validatorjs:master Feb 8, 2023
@profnandaa profnandaa mentioned this pull request Feb 8, 2023
Merged
profnandaa added a commit that referenced this pull request Feb 8, 2023
@profnandaa
fix(docs): add missing locale fr-CF (#2178)
0188a95 
- following #2176
@profnandaa profnandaa mentioned this pull request Aug 3, 2023
Closed
@rntvicente rntvicente mentioned this pull request May 24, 2024
Open
@sahilpawar58 sahilpawar58 mentioned this pull request May 25, 2024
Open
@ArthurMaverick ArthurMaverick mentioned this pull request May 25, 2024
Open
@hunterjc hunterjc mentioned this pull request May 25, 2024
Open
@kaifkh20 kaifkh20 mentioned this pull request May 30, 2024
Open
@Safar123 Safar123 mentioned this pull request May 30, 2024
Open
@IT21149412 IT21149412 mentioned this pull request May 30, 2024
Open
@Achmad-Farid Achmad-Farid mentioned this pull request May 30, 2024
Open
@ahmetilboga2004 ahmetilboga2004 mentioned this pull request May 30, 2024
Merged
@wambugucoder wambugucoder mentioned this pull request May 30, 2024
Open
@TuanNB28 TuanNB28 mentioned this pull request May 30, 2024
Open
@StemmlerSisters StemmlerSisters mentioned this pull request May 30, 2024
Open
@peterboni peterboni mentioned this pull request May 30, 2024
Open
@rntvicente rntvicente mentioned this pull request May 30, 2024
Open
@DefenderK DefenderK mentioned this pull request May 30, 2024
Open
@hunterjc hunterjc mentioned this pull request May 30, 2024
Open
@saileshbro saileshbro mentioned this pull request May 30, 2024
Merged
@malforsaja malforsaja mentioned this pull request May 30, 2024
Merged
@ryanlelek ryanlelek mentioned this pull request May 30, 2024
Open
@ziccardi ziccardi mentioned this pull request May 30, 2024
Open
@MoTarigOs MoTarigOs mentioned this pull request May 30, 2024
Open
@pasang7 pasang7 mentioned this pull request May 30, 2024
Open
@ArthurMaverick ArthurMaverick mentioned this pull request May 31, 2024
Open
@ceconcarlsen ceconcarlsen mentioned this pull request May 31, 2024
Open
@sumandas0 sumandas0 mentioned this pull request May 31, 2024
Open
@avinash977 avinash977 mentioned this pull request May 31, 2024
Open
@vky5 vky5 mentioned this pull request May 31, 2024
Open
@shaneclulow shaneclulow mentioned this pull request May 31, 2024
Open
@isomeradmin isomeradmin mentioned this pull request May 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezkemboi ezkemboi ezkemboi requested changes

@profnandaa profnandaa profnandaa approved these changes

@rubiin rubiin rubiin approved these changes

Assignees
No one assigned
Labels
✅ LGTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cheboi @profnandaa @rubiin @ezkemboi