Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(isIBAN): add Morocco (MA) IBAN format #2025

Merged
merged 3 commits into from Jun 26, 2023

Conversation

lroudge
Copy link
Contributor

@lroudge lroudge commented Aug 12, 2022

Added a regex for Morocco IBAN format in isIBAN validator

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@codecov
Copy link

codecov bot commented Aug 12, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (4ff897b) compared to base (6dba289).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #2025   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          105       105           
  Lines         2334      2334           
  Branches       586       586           
=========================================
  Hits          2334      2334           
Impacted Files Coverage Δ
src/lib/isIBAN.js 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lroudge lroudge marked this pull request as ready for review August 12, 2022 13:57
@lroudge
Copy link
Contributor Author

lroudge commented Aug 23, 2022

HI @WikiRik, if you have a chance to look at this I would be very grateful, thanks!

Copy link
Member

@WikiRik WikiRik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to https://www.iban.com/structure this seems correct

@lroudge
Copy link
Contributor Author

lroudge commented Aug 24, 2022

Hello @chriso, I thought @WikiRik review would be enough to merge this PR but I didn't realize they were not in the list of maintainers. Do you mind taking a look please? Thanks a lot!

Copy link
Contributor

@pano9000 pano9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, from what I could gather online

Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contrib! 🎉

@profnandaa profnandaa merged commit 2440c39 into validatorjs:master Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants