Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace dockerhub with github docker registry #4033

Merged
merged 16 commits into from
Mar 21, 2023
Merged

Conversation

nilsnolde
Copy link
Member

@nilsnolde nilsnolde commented Mar 20, 2023

closes #4029

Let's try with Github Actions, so much easier. On CircleCI it was running with a default machine as well, not the big ones. So probably similar performance. As temp I enabled to build this branch.

Also removes the run- prefix as that's not applicable anymore and since people will have to update the URL they're pulling from anyways, we can break this as well IMO.

Dockerfile Show resolved Hide resolved
@nilsnolde
Copy link
Member Author

BTW, I built the image in https://github.com/valhalla/valhalla/actions/runs/4473531846/jobs/7861023336, but I canceled the build or it'd have pushed this branch's image as latest (would've been fine actually, but still). Tagged ones will also work, I use that in other repos.

michaelkirk
michaelkirk previously approved these changes Mar 20, 2023
Copy link
Contributor

@michaelkirk michaelkirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docker command line is already so minimal that it indeed seems like a good idea to forego the "fancy" docker GH action.

Everything else (also) looks reasonable to me.

@nilsnolde
Copy link
Member Author

Jep that worked, 2 brand new images :)

https://github.com/valhalla/valhalla/pkgs/container/valhalla

Let me revert the test stuff before we merge.

@nilsnolde
Copy link
Member Author

nilsnolde commented Mar 21, 2023

this is also done @kevinkreiser . The 2 PRs should merge cleanly without conflict

BTW, the docker builds take the same time as it took on CircleCI, around 30 mins.

@nilsnolde nilsnolde merged commit 0825735 into master Mar 21, 2023
@nilsnolde nilsnolde deleted the nn-remove-dockerhub branch March 21, 2023 23:50
@nilsnolde
Copy link
Member Author

nilsnolde commented Mar 21, 2023

I’ll also remove the test tag and image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

migrate docker builds to github
3 participants