Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Portugal holidays: fix Carnival date #1694

Merged
merged 2 commits into from Feb 19, 2024

Conversation

DgRosa
Copy link
Contributor

@DgRosa DgRosa commented Feb 19, 2024

Proposed change

This aims to fix an issue with the current weekday of the Carnival holiday in Portugal.
It was set to happen on a Monday when it's always been a Tuesday.

There's not an official government document because Carnival is an optional holiday, there is however a Wikipedia entry with this information.

Closes #1692.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've run make pre-commit, it didn't generate any changes
  • I've run make test, all tests passed locally

I've ran make pre-commit but got the following error message:
Captura de ecrã 2024-02-19, às 11 07 40

Copy link

sonarcloud bot commented Feb 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7958673682

Details

  • 0 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 7945701764: 0.0%
Covered Lines: 10547
Relevant Lines: 10547

💛 - Coveralls

@arkid15r arkid15r changed the title Updated Carnival holiday for Portugal to be on a tuesday Update Portugal: fix Carnival holiday date Feb 19, 2024
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's not an official government document because Carnival is an optional holiday, there is however a Wikipedia entry with this information.

Yeah, it'd be great to include an official reference if any.

🇵🇹 LGTM

@KJhellico any comments? This is quite small fix that could be included into today's release.

Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@arkid15r arkid15r added this pull request to the merge queue Feb 19, 2024
Merged via the queue into vacanza:beta with commit 0eea482 Feb 19, 2024
26 checks passed
@arkid15r arkid15r changed the title Update Portugal: fix Carnival holiday date Update Portugal holidays: fix Carnival date Feb 19, 2024
@arkid15r arkid15r mentioned this pull request Feb 19, 2024
@PPsyrius PPsyrius mentioned this pull request Mar 1, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Carnival date of the "Portugal" calendar
4 participants