mv: fix invalid numbered backup path

[hamflx]

see #6040 (comment)

the gnu mv:

hamflx@hamflx-workstation:~/coreutils/test$ find . -delete && mkdir C D E && touch C/c D/d E/e
hamflx@hamflx-workstation:~/coreutils/test$ mv -T --backup=numbered C E/
hamflx@hamflx-workstation:~/coreutils/test$ tree -a
.
├── D
│   └── d
├── E
│   └── c
└── E.~1~
    └── e

3 directories, 3 files

the uu_mv:

hamflx@hamflx-workstation:~/coreutils/test$ find . -delete && mkdir C D E && touch C/c D/d E/e
hamflx@hamflx-workstation:~/coreutils/test$ ../target/debug/mv -T --backup=numbered C E/
hamflx@hamflx-workstation:~/coreutils/test$ tree -a
.
├── D
│   └── d
└── E
    └── c

2 directories, 2 files

[sylvestre]

Could you please add an highlevel integration test in https://github.com/uutils/coreutils/blob/main/tests/by-util/test_mv.rs ? thanks

[hamflx]

@sylvestre I have added integration test.

[github-actions]

GNU testsuite comparison:

Skip an intermittent issue tests/rm/rm1 (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)

[hamflx]

@sylvestre @tertsdiepraam Is there anything else I need to do if I want this PR to be merged?

[sylvestre]

can it be incremental ? like .2, .3, etc

[hamflx]

I'm trying to keep the logic the same as before. I think this just checks if the numbered backup exists. Only checking for '.1' is enough. If it exists, then we're still using the numbered backup, else we're using simple backup.

[sylvestre]

ping ?

[hamflx]

ping ?

sorry, English isn't my native language. What does "ping" mean?

[sylvestre]

sorry, if you are still working on it :)

[hamflx]

Is there anything else I need to do next?

[hamflx]

I've noticed that there are some compilation errors being reported currently. If you intend to merge this PR, I can go and handle them.

[sylvestre]

please don't share screenshot, it is terrible for search and accessibility :)

(and it is fine, it is an intermittent issue)

[cakebaker]

@hamflx: This is unrelated to your PR.

[github-actions]

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

[sylvestre]

Suggested change

	match path.file_name() {
	Some(file_name) => {
	let mut file_name = file_name.to_os_string();
	file_name.push(suffix);
	path.with_file_name(file_name)
	}
	None => path.with_file_name(suffix),
	}
	let mut file_name = path.file_name().unwrap_or_default().to_os_string();
	file_name.push(suffix);
	path.with_file_name(file_name)

[hamflx]

fixed

[github-actions]

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)

[github-actions]

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)