Upgrade borsh unstable dependency to v1.0 and make it stable #724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I checked manually that even with borsh =v1.0.0 the tests pass.
bgeron
changed the title
Co-authored-by: Ashley Mannix <kodraus@hey.com>
bgeron
changed the title
Very much agree! 👏 I'm not involved in borsh but I'm thinking to start using it.
|
KodrAus
reviewed
Jan 18, 2024
| @@ -71,6 +71,8 @@ fast-rng = ["rng", "rand"] | |||
| sha1 = ["sha1_smol"] | |||
| md5 = ["md-5"] | |||
|
|
|||
| borsh = ["dep:borsh", "dep:borsh-derive"] | |||
There was a problem hiding this comment.
The fact that this works on our MSRV now is great 👍 There's so much I can clean up elsewhere with our dependencies.
kodiakhq bot
pushed a commit
to pdylanross/fatigue
that referenced
this pull request
Jan 19, 2024
Bumps uuid from 1.6.1 to 1.7.0. Release notes Sourced from uuid's releases. 1.7.0 What's Changed Add missing test for invalid parse_str by @CXWorks in uuid-rs/uuid#723 Upgrade borsh unstable dependency to v1.0 and make it stable by @bgeron in uuid-rs/uuid#724 Reduce the package size of uuid by @KodrAus in uuid-rs/uuid#726 Make use of newer Cargo features for specifying dependencies by @KodrAus in uuid-rs/uuid#727 Prepare for 1.7.0 release by @KodrAus in uuid-rs/uuid#728 New Contributors @CXWorks made their first contribution in uuid-rs/uuid#723 @bgeron made their first contribution in uuid-rs/uuid#724 Full Changelog: uuid-rs/uuid@1.6.1...1.7.0 Commits cefc353 Merge pull request #728 from uuid-rs/cargo/1.7.0 3255b54 prepare for 1.7.0 release 403bb17 Merge pull request #727 from uuid-rs/chore/cargo-cleanup b7c6e26 make use of newer Cargo features for specifying dependencies ed13c73 Merge pull request #726 from uuid-rs/chore/pkg-size 2e92a3d Merge pull request #724 from bgeron/borsh-1 38f01ff rename workflow eab4b85 reduce the package size of uuid 421d752 Make the borsh feature work by itself, without having to specify private feat... 2534949 Continue making feature borsh stable, as suggested by @KordAus Additional commits viewable in compare view Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase. Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: @dependabot rebase will rebase this PR @dependabot recreate will recreate this PR, overwriting any edits that have been made to it @dependabot merge will merge this PR after your CI passes on it @dependabot squash and merge will squash and merge this PR after your CI passes on it @dependabot cancel merge will cancel a previously requested merge and block automerging @dependabot reopen will reopen this PR if it is closed @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I checked manually that even with borsh =v1.0.0 the tests pass.