Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow single letter user id #3991

Merged
merged 6 commits into from
Oct 8, 2024
Merged

feat: allow single letter user id #3991

merged 6 commits into from
Oct 8, 2024

Conversation

rkj
Copy link
Contributor

@rkj rkj commented Oct 6, 2024

They do work - I use one (by login using Authelia), but then I am not able to update the profile to update avatar or add comment because "Invalid username: r" errors.

I don't know go at all, so not sure how to add proper test for this.

Unverified

No user is associated with the committer email.
They do work - I use one and login using Authelia, but then I am not able to update the profile to update avatar or add comment because "Invalid username: r" errors
@rkj rkj requested a review from boojack as a code owner October 6, 2024 04:04
@RoccoSmit
Copy link
Contributor

This change allows for 1 char usernames but not 2 and then > 2 again
Ideally a new regex expression (or other validation as regexes are hard to decipher) would be created for usernames. UIDMatcher is for checking user IDs which has a different structure to usernames

Roman Kamyk added 5 commits October 6, 2024 07:39

Unverified

No user is associated with the committer email.

Unverified

No user is associated with the committer email.

Unverified

No user is associated with the committer email.

Unverified

No user is associated with the committer email.

Unverified

No user is associated with the committer email.
@rkj
Copy link
Contributor Author

rkj commented Oct 6, 2024

Added a test and updated the regexp, I have zero context for this project, so not really sure how to make some more complex change.

Copy link
Collaborator

@johnnyjoygh johnnyjoygh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnnyjoygh johnnyjoygh changed the title Allow single letter user id. feat: allow single letter user id Oct 8, 2024
@johnnyjoygh johnnyjoygh merged commit 310f147 into usememos:main Oct 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants