Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor double conditional into one #3118

Merged
merged 5 commits into from
Sep 15, 2023
Merged

Refactor double conditional into one #3118

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f911dd9
refactor: change double conditional to one
Rodrigo-Novas Sep 4, 2023
05869b2
refactor: change to ternary if
Rodrigo-Novas Sep 5, 2023
306c04a
Merge branch 'main' into feature/fix-redundant-conditional
Rodrigo-Novas Sep 5, 2023
9b234ab
Merge branch 'main' into feature/fix-redundant-conditional
Rodrigo-Novas Sep 7, 2023
f9f2eb6
Update src/urllib3/response.py
pquentin Sep 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 1 addition & 5 deletions src/urllib3/response.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -878,11 +878,7 @@ def read(

data = self._raw_read(amt)

flush_decoder = False
if amt is None:
flush_decoder = True
elif amt != 0 and not data:
flush_decoder = True
flush_decoder = amt is None or (amt != 0 and not data)

if not data and len(self._decoded_buffer) == 0:
return data
Expand Down