Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix UNRESERVED regex. #2900

Merged
merged 6 commits into from Jan 29, 2023
Merged

Fix UNRESERVED regex. #2900

merged 6 commits into from Jan 29, 2023

Conversation

kenballus
Copy link
Contributor

Addresses #2899

@kenballus kenballus changed the title remove exclamation point from UNRESERVED Fix UNRESERVED regex. Jan 28, 2023
sethmlarson
sethmlarson approved these changes Jan 29, 2023
View reviewed changes
Copy link
Member

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great eye, thank you for this. Would you also open a PR to the 1.26.x branch with this fix?

@sethmlarson sethmlarson merged commit 29c4bcc into urllib3:main Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sethmlarson sethmlarson sethmlarson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kenballus @sethmlarson