Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor internal APIs to use our own HTTPResponse #2649

Merged
merged 42 commits into from
Nov 7, 2022
Merged

Refactor internal APIs to use our own HTTPResponse #2649

merged 42 commits into from
Nov 7, 2022

Commits on Jul 7, 2022

  1. init commit of changes to be made for disscusion

    @shadycuz
    shadycuz committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    c5ed237 View commit details
    Browse the repository at this point in the history

  2. refactor common types into its own util class

    @shadycuz
    shadycuz committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    25a8474 View commit details
    Browse the repository at this point in the history

  3. return HTTPResponse object from urlopen

    @shadycuz
    shadycuz committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    44259be View commit details
    Browse the repository at this point in the history

  4. add length to HTTPResponse

    @shadycuz
    shadycuz committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    2964e87 View commit details
    Browse the repository at this point in the history

  5. pass retries to HTTPResponse

    @shadycuz
    shadycuz committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    527927e View commit details
    Browse the repository at this point in the history

  6. linting fixes

    @shadycuz
    shadycuz committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    824e5d8 View commit details
    Browse the repository at this point in the history

  7. fix mypy typing issues

    @shadycuz
    shadycuz committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    ea254b9 View commit details
    Browse the repository at this point in the history

  8. attempt to fix test case

    @shadycuz
    shadycuz committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    6f67900 View commit details
    Browse the repository at this point in the history

  9. add comment on why import is in method

    @shadycuz
    shadycuz committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    1a77d07 View commit details
    Browse the repository at this point in the history

  10. add back missing type ignore

    @shadycuz
    shadycuz committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    781a629 View commit details
    Browse the repository at this point in the history

  11. fix raise_once func by updating behavior

    @shadycuz
    shadycuz committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    a2cf139 View commit details
    Browse the repository at this point in the history

  12. re-implemt custom reponse class feature

    @shadycuz
    shadycuz committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    f833362 View commit details
    Browse the repository at this point in the history

  13. make header parsing work again

    @shadycuz
    shadycuz committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    1c33e3f View commit details
    Browse the repository at this point in the history

  14. refactor from_httplib into getresponse

    @shadycuz
    shadycuz committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    40dc0f3 View commit details
    Browse the repository at this point in the history

  15. remove response class override

    @shadycuz
    shadycuz committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    4328582 View commit details
    Browse the repository at this point in the history

  16. remove duplicate length

    @shadycuz
    shadycuz committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    314aa61 View commit details
    Browse the repository at this point in the history

  17. types and comments cleanup

    @shadycuz
    shadycuz committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    3eeb8ee View commit details
    Browse the repository at this point in the history

  18. Revert "refactor common types into its own util class" 

    This reverts commit 3dbadc6.
    @shadycuz
    shadycuz committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    0613e3d View commit details
    Browse the repository at this point in the history

  19. unconditionally convert .msg into HTTPHeaderDict

    @shadycuz
    shadycuz committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    f0e8684 View commit details
    Browse the repository at this point in the history

  20. reorder arguments to match order listed in the constructor

    @shadycuz
    shadycuz committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    0c1bebd View commit details
    Browse the repository at this point in the history

  21. refactor _absolute_url into multiple helper functions

    @shadycuz
    shadycuz committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    ae81873 View commit details
    Browse the repository at this point in the history

  22. set connection backed to response_conn 

    If not lots of tests fail because of double closing the connection
    @shadycuz
    shadycuz committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    55f973e View commit details
    Browse the repository at this point in the history

  23. refactor out httplib_request_kw 

    Now we use pass the needed parameters directly to _make_request
    @shadycuz
    shadycuz committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    01cc47d View commit details
    Browse the repository at this point in the history

  24. make mock func behave like the real func

    @shadycuz
    shadycuz committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    8c0f880 View commit details
    Browse the repository at this point in the history

  25. remove request_ prefix to match other func's like urlopen

    @shadycuz
    shadycuz committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    9df9e73 View commit details
    Browse the repository at this point in the history

  26. force kwargs for getresponse

    @shadycuz
    shadycuz committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    b8f6bf6 View commit details
    Browse the repository at this point in the history

  27. use kwargs when passing body and headers

    @shadycuz
    shadycuz committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    ee01d14 View commit details
    Browse the repository at this point in the history

  28. make url_from_pool a private api

    @shadycuz
    shadycuz committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    ce50569 View commit details
    Browse the repository at this point in the history

  29. make url_from_connection a private API

    @shadycuz
    shadycuz committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    12ed1d8 View commit details
    Browse the repository at this point in the history

  30. remove comment explaining why import happens further down

    @shadycuz
    shadycuz committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    b3bd9fa View commit details
    Browse the repository at this point in the history

  31. remove some whitespace

    @shadycuz
    shadycuz committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    bf7eb2e View commit details
    Browse the repository at this point in the history

  32. update param order and documentation 

    I decided o keep this in sync with urlopen
    @shadycuz
    shadycuz committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    1acbce5 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2022

  1. update docstring and param order for getresponse 

    This follows the same as urlopen and _make_request
    @shadycuz
    shadycuz committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    32aa265 View commit details
    Browse the repository at this point in the history

  2. add tests for getresponse returning a urllib3 HTTPResponse

    @shadycuz
    shadycuz committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    c1d9d59 View commit details
    Browse the repository at this point in the history

  3. add change log entry

    @shadycuz
    shadycuz committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    4118fae View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2022

  1. Try to make integration tests pass

    @sethmlarson
    sethmlarson committed Jul 11, 2022
    Configuration menu
    Copy the full SHA
    8e5bb07 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2022

  1. Merge pull request #1 from sethmlarson/pr-2649 

    Try to make integration tests pass
    @shadycuz
    shadycuz committed Jul 16, 2022
    Configuration menu
    Copy the full SHA
    67df385 View commit details
    Browse the repository at this point in the history

  2. test that getresponse throws ResponseNotReady

    @shadycuz
    shadycuz committed Jul 16, 2022
    Configuration menu
    Copy the full SHA
    c0ea937 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2022

  1. Merge branch 'main' into refactor_http_response

    @sethmlarson
    sethmlarson committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    4804b83 View commit details
    Browse the repository at this point in the history

  2. Remove _HttplibResponse

    @sethmlarson
    sethmlarson committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    1d2321c View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2022

  1. Skip failing psf/requests tests for chunking

    @sethmlarson
    sethmlarson committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    bc48f62 View commit details
    Browse the repository at this point in the history

  2. Update 2648.feature.rst

    @sethmlarson
    sethmlarson committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    54be61a View commit details
    Browse the repository at this point in the history