Fix HTTPSConnection/HTTPConnection reuse unapplied socket timeout bug #2645 #2646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When making an HTTP(s) request to a host for which a connection has
already been established, this connection is reused however the timeout
provided is only applied to the HTTPSConnection/HTTPConnection object
but not it's underlying socket (the original requests timeout remains).
Therefore, if the initial request has a short timeout and a subsequent
request is initiated that happens to take more time than the initial,
the following error will be raised in accordance with the original
requests timeout:
urllib3.exceptions.ProtocolError: ('Connection aborted.', TimeoutError('The write operation timed out'))
This commit fixes this be applying the timeout to the underlying socket.
Note this bug applied to HTTPConnections and HTTPSConnections using the
stdlib SSLContext backend but not HTTPSConnections using the PyOpenSSLContext
backend.
Ryangwaite
force-pushed
the
fix-initial-conn-timeout-persists
branch
from
67252fd
to
7417026
Compare
|
Thank you for submitting this bug, I've created #2792 which I'm closing this as a duplicate of. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2645