remove networkSeed input from setKeys / genKeyfile flows #85

c-johnson · 2019-03-22T22:29:48Z

This PR makes several changes to the setKeys / generateKeyfile flows:

Automatically generate a random network seed if user logs in using a non-urbit-generated wallet. Store this value in memory when new keys are set.
Since network seeds are now always generated, hide the 'network seed' input on both setKeys and genKeyfile views. User doesn't need to interact with network seed at all anymore.
Change the copy to reflect the above flow.

There's one sticking point with the above flow; if the non-urbit-wallet user refreshes the page between setting network keys and generating their keyfile, the network seed they use is lost. It's fairly punishing if a user accidentally refreshes between steps. Some options we have include:

A) adding the networkSeed to localStorage,
B) making the networkSeed generation deterministic (like urbit wallet case)
C) download the keyfile automatically when new keys are set (combining the two actions into one)

For now Mark and I decided to just inform the user to download their keyfile immediately, but curious if others (@iamwillkim ?) have input here.

…enKeyfile view

… if they haven’t been set in this session - Remove networkSeed inputs on genKeyfile/setKeys pages

Fang-

This actually feels pretty good, flow-wise. I'd say this is a good solution. Left some comments with minor change requests though!

Additionally, we may want the "Ok ->" from the transaction confirmation screen to be "Download keyfile ->" instead, if that's doable with the forward-only router we have now/are getting.

slow confirm?

Fang- · 2019-03-25T18:46:55Z

src/Bridge.js

+// import * as azimuth from 'azimuth-js'
+// import { CONTRACT_ADDRESSES } from './lib/contracts'
+// import { walletFromMnemonic } from './lib/wallet'
+


Eww, commented code! (:

Ah, yeah. This was just a convenience for the commented-out development mode workflow. Removed it.

Fang- · 2019-03-25T18:48:48Z

src/Bridge.js

@@ -92,20 +99,22 @@ class Bridge extends React.Component {
  //
  //   this.setState({
  //     routeCrumbs: Stack([
-  //       ROUTE_NAMES.CREATE_GALAXY,
+  //       // ROUTE_NAMES.CREATE_GALAXY,
+  //       // ROUTE_NAMES.SHIP,


I don't see anything about this in your commit messages, but I think these (and the couple lines below) are just dev setup tweaks?

Yep; hopefully that's okay. There were a couple issues with the flow so I just updated it.

Fang- · 2019-03-25T18:54:12Z

src/views/GenKeyfile.js

+      networkSeedWarning = (
+        <P>
+          <b>Warning: </b>
+          { "No network seed detected. To generate a keyfile, you must reset your networking keys." }


This should also inform the user of the alternative: getting into a state where we can detect networking seed. So, "If you've previously set networking keys while logged in with a master ticket or management mnemonic, logging in with that again might allow you to find the current networking seed." or something that's worded perhaps a little bit better.

How about "Try logging in with your master ticket or management mneumonic if you want to keep your current networking keys" ?

Problem is it would only work if the current keys were actually set using those.
Maybe "Try logging in with your master ticket or management mnemonic. Alternatively, reset your keys."? All of this feels pretty aggressive if the user isn't aware that this is "quick and easy", but maybe it's good if they just find out for themselves?

Fang- · 2019-03-25T18:56:05Z

src/Bridge.js

@@ -252,6 +268,8 @@ class Bridge extends React.Component {
                addToPointCache={ this.addToPointCache }
                pointCursor={ pointCursor }
                pointCache={ pointCache }
+                networkSeedCache= { networkSeedCache }
+                setNetworkSeedCache= { this.setNetworkSeedCache }


React Q, to confirm my understanding: putting these as properties into the View is what makes these accessible by other components?

Right. If you have some component Foo, then <Foo foo=1 bar=2 /> is that component with the foo and bar properties set to 1 and 2 respectively. In src/Bridge.js, View is actually just whatever component is currently being pointed at by the router, so it gets passed all the properties you see listed there.

Fang- · 2019-03-25T20:36:53Z

src/views/SetKeys.js

          <P>
          {
-             `If you've authenticated with a master ticket or management proxy
-              mnemonic, a seed will be generated for you automatically.`
+            `Once the transaction is sent, please generate your Arvo keyfile immediately.`


This sentence needs more gravity. We should probably put it in one of those orange warning boxes, like the one we present when you try to configure keys for the very first time.

Might also want to add a brief description why. "Your network seed is not deterministic. Once the transaction ..."

Fang- · 2019-03-25T21:07:18Z

Also I guess it's a little silly that on the "download keyfile" page, if literally the only thing you can do is click "generate", you still need to click that manually. We should just remove that button and auto-generate when we can.

Fang- · 2019-03-26T23:51:34Z

src/views/SetKeys.js

@@ -122,22 +124,34 @@ class SetKeys extends React.Component {
    })
  }

+  randomHex(len) {


Looks like web3 has a function for this. Supposedly "cryptographically strong". We should use that instead of rolling our own.

So I tried this out, and it turns out the function is pretty borked; it doesn't generate strings of consistent length >.<. How important is 'cryptographic strength' here do you think?

web3/web3.js#1490

sigh

Just slap a //TODO use web3.utils.randomHex, see web3.js#1490 in there and call it a day. web3.js is such a shitshow rn. ):

c-johnson · 2019-03-29T19:46:50Z

Also I guess it's a little silly that on the "download keyfile" page, if literally the only thing you can do is click "generate", you still need to click that manually

Yeah, this page is really sparse, and linking to it after setting your keys feels overly complicated.

Could we just move this to the point detail page? At the bottom, after "Public Keys", we just have a section called Arvo Keyfile. If your keys have been set, it just presents you with a download button. If not, it directs you to set your keys. What do you think?

… this session.

Fang- · 2019-03-29T20:04:39Z

src/views/SetKeys.js

+              <h3 className={'mb-2'}>{'Warning'}</h3>
+              {
+                `Your network seed could not be derived automatically. We've
+                generated a random one for you, but you must download your Arvo


Suggested change

generated a random one for you, but you must download your Arvo

generated a random one for you, so you must download your Arvo

Fang- · 2019-03-29T20:05:48Z

Could we just move this to the point detail page?

That might be better, flow-wise, as long as it doesn't need to be scrolled into view. @jyng thoughts?

…ust set networking keys

c-johnson · 2019-04-01T05:35:53Z

Ok, just pushed the following improvements:

Automatically generate your keyfile on genKeyfile when you load the page
Add "Download Keyfile" link to sentTransaction after setting your keys
Shored up the copy per our discussion

Lmk if you see anything missing!

Fang- · 2019-04-01T15:37:05Z

Nice! This is good, I like this flow.

The generate keyfile page seems to still show the "generating keyfile" text, even if it fails. If we remove that, and put the warning in a proper warning box like on the "set keys" page, then this should be good to be merged in. (:

c-johnson · 2019-04-01T17:29:13Z

@Fang- Whoops, forgot to add the conditional in. Alright, it's fixed and merged.

c-johnson added 6 commits March 21, 2019 12:34

- WIP: Add networkSeedCache to copy network seed used in setKeys to g…

223a2dd

…enKeyfile view

- Uppercase hex values (was causing some error)

36c1beb

- Automatically download your keyfile when you set new networking keys.

5f71b99

- Add copy to genKeyfile page, instructing you to set networking keys…

23dbfee

… if they haven’t been set in this session - Remove networkSeed inputs on genKeyfile/setKeys pages

Merge branch 'master' into gen-keyfile-improvements

42d9c64

- Change copy instructing user to download keyfile automatically

d29b35b

alexmatz requested a review from Fang- March 22, 2019 22:46

Fang- requested changes Mar 25, 2019

View reviewed changes

Fang- reviewed Mar 26, 2019

View reviewed changes

c-johnson added 2 commits March 27, 2019 14:10

- Remove development flow imports

05c1914

Merge branch 'master' into gen-keyfile-improvements

133c307

Fang- mentioned this pull request Mar 28, 2019

Minor UI issues around network seed entry #65

Closed

- add TODO for web3.utils.randomHex

6952d2f

- Added warning for nondeterministic keys to download your keyfile in…

17b7424

… this session.

Fang- reviewed Mar 29, 2019

View reviewed changes

c-johnson added 2 commits March 31, 2019 21:06

- Add “download keyfile” button to the sentTransaction page if they j…

bdd3bc2

…ust set networking keys

- Streamline genKeyfile view, making everything automatic

d593175

- Add ‘loaded’ conditional to genKeyfile display message

b7de3ed

c-johnson merged commit 153508b into master Apr 1, 2019

c-johnson deleted the gen-keyfile-improvements branch April 1, 2019 17:28

This was referenced Apr 11, 2019

UI bugs when using mnemonic option for generating an urbit keyfile #71

Closed

Non-existent instructions for resetting keys with Urbit Master Ticket #57

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

remove networkSeed input from setKeys / genKeyfile flows #85

remove networkSeed input from setKeys / genKeyfile flows #85

c-johnson commented Mar 22, 2019

Fang- left a comment

Fang- Mar 25, 2019

c-johnson Mar 27, 2019

Fang- Mar 25, 2019

c-johnson Mar 27, 2019

Fang- Mar 25, 2019

c-johnson Mar 27, 2019

Fang- Mar 27, 2019 •

edited

Fang- Mar 25, 2019

jtobin Mar 25, 2019 •

edited

Fang- Mar 25, 2019

Fang- commented Mar 25, 2019

Fang- Mar 26, 2019

c-johnson Mar 28, 2019

Fang- Mar 28, 2019

c-johnson commented Mar 29, 2019

Fang- Mar 29, 2019

Fang- commented Mar 29, 2019

c-johnson commented Apr 1, 2019

Fang- commented Apr 1, 2019

c-johnson commented Apr 1, 2019

	generated a random one for you, but you must download your Arvo
	generated a random one for you, so you must download your Arvo

remove networkSeed input from setKeys / genKeyfile flows #85

remove networkSeed input from setKeys / genKeyfile flows #85

Conversation

c-johnson commented Mar 22, 2019

Fang- left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Fang- Mar 27, 2019 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jtobin Mar 25, 2019 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Fang- commented Mar 25, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

c-johnson commented Mar 29, 2019

Choose a reason for hiding this comment

Fang- commented Mar 29, 2019

c-johnson commented Apr 1, 2019

Fang- commented Apr 1, 2019

c-johnson commented Apr 1, 2019

Fang- Mar 27, 2019 •

edited

jtobin Mar 25, 2019 •

edited