Replace throw on missing env with warning #1311
Merged
+69
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CahidArda
force-pushed
the
DX-1333-rm-throws-on-missing-env
branch
from
4929d55 to
6ab0fb8
Compare
|
doesn't work as expected with Turbo & Vercel. More info available at Linear. |
because of vercel pre-rendering, the error was thrown when turbo was used
|
Turbo repo was deployed when I replaced throws with warnings altogether |
ytkimirti
previously approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we threw when the env variables were missing. This is usually fine, but in turbo we had to add the Upstash Redis env variables to turbo.json (under build.env).
This is not ideal. Instead, we now check at runtime when the request is being sent. If the credentials are missing, we throw.