Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(relative): handle different windows drive letters #158

Merged
merged 1 commit into from Jan 10, 2024
Merged

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Jan 10, 2024

πŸ”— Linked issue

resolves #143

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Small note: While current fix seemed reasonable to me, I am also amazed that resolve function internally makes paths like /C:/ perhaps with some better fixes of route cause workaround like this and #142 wouldn't be required..

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pi0 pi0 requested a review from danielroe January 10, 2024 13:46
@pi0 pi0 merged commit faa2b11 into main Jan 10, 2024
1 check passed
@pi0 pi0 deleted the fix/win-relative branch January 10, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

relative judgment error in win32 when from and to in different disk
1 participant