refactor!: drop murmurHash support
#104
Merged
+4
−150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was only using this project for MurmurHash implementation. its speed and efficiency in non-cryptographic contexts, making it ideal for scenarios where hash functions need to be fast but not necessarily resistant to collision attacks. maybe a MurmurHash3 could be added or loaded optionally? |
|
I have made an issue to consider adding it back as new subpath #156 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ohash used to use murmurhash however due to overlaps + implementation errors initially we have switched to sha256+base64.
We kept
murmurhashfor backward compact but it seems almost unused, taking install size bytes.Note
If you were using this function and have reasons to need it still, please raise an issue to bring it back!