Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inspect BigInts as 123n instead of BigInt(123) #851

Merged
merged 2 commits into from
Apr 26, 2022

Conversation

papandreou
Copy link
Member

@papandreou papandreou commented Apr 26, 2022

Reads nicer -- I wasn't aware of this syntax when I implemented the BigInt type.

Keep using the BigInt(123) syntax in the test suite to prevent breaking in environments where the parser doesn't allow it.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@papandreou papandreou self-assigned this Apr 26, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@papandreou papandreou force-pushed the feature/inspectAsBigintLiteral branch from ed29afd to d1a0539 Compare April 26, 2022 13:19
@papandreou papandreou merged commit a6107ac into master Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant